Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Black and Flake8 deps #416

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Bump Black and Flake8 deps #416

merged 2 commits into from
Dec 13, 2020

Conversation

BeyondEvil
Copy link
Contributor

No description provided.

@BeyondEvil BeyondEvil mentioned this pull request Dec 13, 2020
Merged
@jkowalleck
Copy link
Contributor

jkowalleck commented Dec 13, 2020 •
edited
Loading

@BeyondEvil Don't know how hard you rely on having the latest dependencies(pipenv, npm, ...) for the test/build env.

In case you bump those deps manual often, you could have a bot that PRs dependency updates for Keeping your dependencies updated automatically
For example: you could have this bot run scheduled(once a week) as a github action.

@BeyondEvil
Copy link
Contributor Author

Good idea @jkowalleck

Not sure dependabot supports updating pre-commit configs. But I'll check.

@BeyondEvil
Copy link
Contributor Author

Seems there are open tickets for dependabot to support pre-commit:

dependabot/dependabot-core#1524

dependabot/dependabot-core#2040

Will hold off until that support is added.

@gnikonorov gnikonorov added Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. ) skip-changelog Can be missed from the changelog. labels Dec 13, 2020
@gnikonorov
Copy link
Member

Seems there are open tickets for dependabot to support pre-commit:

dependabot/dependabot-core#1524

dependabot/dependabot-core#2040

Will hold off until that support is added.

Noting that dependabot is being considered added here: #419

gnikonorov
gnikonorov requested changes Dec 13, 2020
View reviewed changes
Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and one ask, but otherwise LGTM

Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
gnikonorov
gnikonorov approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ship it!

@BeyondEvil BeyondEvil merged commit bbcc0f2 into pytest-dev:master Dec 13, 2020
@BeyondEvil BeyondEvil deleted the update-deps branch December 13, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnikonorov gnikonorov gnikonorov approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees

@BeyondEvil BeyondEvil

Labels
Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. ) skip-changelog Can be missed from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeyondEvil @jkowalleck @gnikonorov