Long filenames break rendering. #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pypi#338. I opted to fix this with a CSS overflow property. In most cases, it shouldn't look different, but for very long file names, such as in the Pillow project, you'll be able to see it. I notice that the compiled CSS is under version control; that seems undesirable to me. Would there be any objections to adding something like `warehouse/static/css/*.css` to `.gitignore`? How would that interact with the `manifest.json`?
|
We do check in the compiled CSS, largely so that working on Warehouse doesn't require having the CSS toolchain installed unless you're actively working on the CSS. Moving away from committing the compiled CSS would likely require setting up the docker containers so that they installed the node.js tooling that we need and ran |
dstufft
added a commit
that referenced
this pull request
Aug 5, 2015
Long filenames break rendering.
|
Gotcha, thanks for the clarification. I might put some work into that, but as it's not a blocker for replacing PyPI, it comes in further down the priority list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338.
I opted to fix this with a CSS overflow property. In most cases, it shouldn't look different, but for very long file names, such as in the Pillow project, you'll be able to see it.
I notice that the compiled CSS is under version control; that seems undesirable to me. Would there be any objections to adding something like
warehouse/static/css/*.cssto.gitignore? How would that interact with themanifest.json?As per the ancient prophecy, here is a cute animal picture:
"Hazel beim Spiel" by SamyG - Own work. Licensed under CC BY 3.0 via Wikimedia Commons - https://commons.wikimedia.org/wiki/File:Hazel_beim_Spiel.jpeg#/media/File:Hazel_beim_Spiel.jpeg)