Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long filenames break rendering #338

Closed
mgedmin opened this issue Dec 3, 2014 · 1 comment · Fixed by #585
Closed

Long filenames break rendering #338

mgedmin opened this issue Dec 3, 2014 · 1 comment · Fixed by #585
Labels
UX/UI design, user experience, user interface

Comments

@mgedmin
Copy link

mgedmin commented Dec 3, 2014

Here's how https://warehouse.python.org/project/Pillow/ looks on my 1366x768 laptop:

ekrano nuotrauka is 2014-12-03 11 48 31

The culprit appears to be

ekrano nuotrauka is 2014-12-03 11 49 22

I'm sure this can be fixed with some CSS.

@mgedmin
Copy link
Author

mgedmin commented Dec 3, 2014

Adding .downloads td { max-width: 400px; } to the CSS fixes this (for my screen size):

ekrano nuotrauka is 2014-12-03 11 56 18

Overflow is handled reasonably, IMHO:
ekrano nuotrauka is 2014-12-03 11 56 59

@dstufft dstufft modified the milestone: Become PyPI Mar 14, 2015
@dstufft dstufft added the UX/UI design, user experience, user interface label Aug 4, 2015
wlonk added a commit to wlonk/warehouse that referenced this issue Aug 5, 2015
Fixes pypi#338.

I opted to fix this with a CSS overflow property. In most cases, it
shouldn't look different, but for very long file names, such as in the
Pillow project, you'll be able to see it.

I notice that the compiled CSS is under version control; that seems
undesirable to me. Would there be any objections to adding something
like `warehouse/static/css/*.css` to `.gitignore`? How would that
interact with the `manifest.json`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX/UI design, user experience, user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants