Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin interface for review of flagged packages #6062

Closed
brainwane opened this issue Jun 21, 2019 · 0 comments
Closed

admin interface for review of flagged packages #6062

brainwane opened this issue Jun 21, 2019 · 0 comments
Labels
admin Features needed for the Admin UI (people running the site) feature request malware-detection Issues related to automated malware detection.
Milestone
Package signing &...

Comments

@brainwane
Copy link
Contributor

We're working on a system to detect malicious uploads (per #4998). It's going to be a pipeline where automated systems run checks, flag packages/projects for deletion/review/ok, etc.

So this issue is for a feature in the admin interface where administrators/moderators (#4011) can review those flagged projects and releases and decide what to accept/reject.

We'll probably also want to use this if/when we implement a mechanism for users to report packages (#3896), and if/when we start automatically checking uploaded packages for compliant metadata and installability (#194).
@brainwane brainwane added feature request admin Features needed for the Admin UI (people running the site) labels Jun 21, 2019
This was referenced Jun 21, 2019
Open
Closed
@xmunoz xmunoz added the malware-detection Issues related to automated malware detection. label Dec 13, 2019
ewdurbin pushed a commit that referenced this issue Jan 10, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
84eac93 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 10, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
03801f1 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 13, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
fa3d2c5 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 13, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
ce0b56a 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 16, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
23cbeff 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 17, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
084a27b 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Jan 27, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
733238a 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Feb 3, 2020
@xmunoz
Add verdicts view filtering capabilities #6062. (#7322)
31b711c 
*  Add verdicts view filtering capabilities #6062.

* Code review changes.

- Refactor tests to be parametrized.
- Pass `_query` to `route_path` in template.
- Remove `is None` from filter query, it adds nothing.
ewdurbin pushed a commit that referenced this issue Feb 6, 2020
@xmunoz
Add verdict administrator review. Fixes #6062. (#7339)
32ed6ed 
* Add verdict administrator review. Fixes #6062.

- Add new `admin.verdicts.review` endpoint
- Change layout of verdict list and detail view and add forms
- Change sort order of the MalwareChecks, and update the tests

* Code review changes.

- Rename MalwareVerdict field `administrator_verdict` to `reviewer_verdict`.
- Change verdict review permission from `admin` to `moderator`.
woodruffw pushed a commit to trail-of-forks/warehouse that referenced this issue Feb 7, 2020
@xmunoz @woodruffw
Add rudimentary verdicts view. Progress on pypi#6062. (pypi#7207)
3f89a86 
* Add rudimentary verdicts view. Progress on pypi#6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
woodruffw pushed a commit to trail-of-forks/warehouse that referenced this issue Feb 7, 2020
@xmunoz @woodruffw
Add verdicts view filtering capabilities pypi#6062. (pypi#7322)
700694d 
*  Add verdicts view filtering capabilities pypi#6062.

* Code review changes.

- Refactor tests to be parametrized.
- Pass `_query` to `route_path` in template.
- Remove `is None` from filter query, it adds nothing.
ewdurbin pushed a commit that referenced this issue Feb 11, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
f80d83f 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Feb 11, 2020
@xmunoz @ewdurbin
Add verdicts view filtering capabilities #6062. (#7322)
10573b3 
*  Add verdicts view filtering capabilities #6062.

* Code review changes.

- Refactor tests to be parametrized.
- Pass `_query` to `route_path` in template.
- Remove `is None` from filter query, it adds nothing.
ewdurbin pushed a commit that referenced this issue Feb 11, 2020
@xmunoz @ewdurbin
Add verdict administrator review. Fixes #6062. (#7339)
b50e5cf 
* Add verdict administrator review. Fixes #6062.

- Add new `admin.verdicts.review` endpoint
- Change layout of verdict list and detail view and add forms
- Change sort order of the MalwareChecks, and update the tests

* Code review changes.

- Rename MalwareVerdict field `administrator_verdict` to `reviewer_verdict`.
- Change verdict review permission from `admin` to `moderator`.
ewdurbin pushed a commit that referenced this issue Feb 18, 2020
@xmunoz @ewdurbin
Add rudimentary verdicts view. Progress on #6062. (#7207)
328b0ee 
* Add rudimentary verdicts view. Progress on #6062.

Also, add some better testing logic for wiped_out condition.

* Code review changes.

- Conditionally show fields that are populated
- JSON pretty formatting

* Fix unit test bug.

- Use `get` instead of `filter` to look up verdict by pkey.

* simplify unit tests for verdicts view
ewdurbin pushed a commit that referenced this issue Feb 18, 2020
@xmunoz @ewdurbin
Add verdicts view filtering capabilities #6062. (#7322)
6fe43a3 
*  Add verdicts view filtering capabilities #6062.

* Code review changes.

- Refactor tests to be parametrized.
- Pass `_query` to `route_path` in template.
- Remove `is None` from filter query, it adds nothing.
ewdurbin pushed a commit that referenced this issue Feb 18, 2020
@xmunoz @ewdurbin
Add verdict administrator review. Fixes #6062. (#7339)
1d3791b 
* Add verdict administrator review. Fixes #6062.

- Add new `admin.verdicts.review` endpoint
- Change layout of verdict list and detail view and add forms
- Change sort order of the MalwareChecks, and update the tests

* Code review changes.

- Rename MalwareVerdict field `administrator_verdict` to `reviewer_verdict`.
- Change verdict review permission from `admin` to `moderator`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin Features needed for the Admin UI (people running the site) feature request malware-detection Issues related to automated malware detection.
Projects
None yet
Milestone
Package signing & detection/verification
Development

No branches or pull requests
2 participants
@brainwane @xmunoz