Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX to SlitTraceBitMask #1848

Merged
merged 3 commits into from
Sep 6, 2024
Merged

HOTFIX to SlitTraceBitMask #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b8c30
fix it
debora-pe Aug 30, 2024
ef9cca8
update docs
debora-pe Aug 30, 2024
2739521
Merge branch 'develop' into fix_spatflex
debora-pe Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/releases/1.16.1dev.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ Bug Fixes
- Fix error "ValueError: setting an array element with a sequence. The requested
array has an inhomogeneous shape after 1 dimensions..." occurring when unpacking
the SpecObj spectrum but having an attribute of the SpecObj object that is None.
- Fixed an hidden bug that was causing the spatial flexure to fail. The bug was in the
`SlitTraceBitMask` class, where the function `exclude_for_flexure()` was not returning
the 'BOXSLIT' flag.



Expand Down
2 changes: 1 addition & 1 deletion pypeit/slittrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def exclude_for_reducing(self):
def exclude_for_flexure(self):
# Ignore these flags when performing a flexure calculation
# Currently they are *all* of the flags..
return ['SHORTSLIT', 'USERIGNORE', 'BADWVCALIB', 'BADTILTCALIB', 'BADALIGNCALIB',
return ['SHORTSLIT', 'BOXSLIT', 'USERIGNORE', 'BADWVCALIB', 'BADTILTCALIB', 'BADALIGNCALIB',
profxj marked this conversation as resolved.
Show resolved Hide resolved
'SKIPFLATCALIB', 'BADFLATCALIB', 'BADSKYSUB', 'BADEXTRACT']


Expand Down
Loading