HOTFIX to SlitTraceBitMask #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1848 +/- ##
========================================
Coverage 38.03% 38.03%
========================================
Files 211 211
Lines 48975 48975
========================================
+ Hits 18626 18627 +1
+ Misses 30349 30348 -1 ☔ View full report in Codecov by Sentry. |
profxj
requested changes
Aug 31, 2024
There was a problem hiding this comment.
one thing to chew on.
might be good to have @kbwestfall 's input too
|
Thanks for the reviews. Unfortunately this fixed only one cause of the failed spatial flexure. I'm working on improving the spatial flexure calculation, but I'll have another PR for that. I am merging this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an hotfix to
SlitTraceBitMaskbut was causing the spatial flexure process to not being able to find the shift.I'll still run the tests to make sure that the problem is fixed in every dataset.
Hopefully, this resolves issue #1843