Do not print error if exit with SystemExit #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case Python will automatically convey the content by setting the exit code and we do not print on stderr when exiting with success. Signed-off-by: Bernat Gabor <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 93.97% 93.95% -0.03%
==========================================
Files 86 86
Lines 4184 4185 +1
==========================================
Hits 3932 3932
- Misses 252 253 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, Python will automatically convey the content by setting the
exit code and we do not print on stderr when exiting with success.
Resolves #1885.