Do not print error if exit with SystemExit (#1886)

In this case Python will automatically convey the content by setting the exit code and we do not print on stderr when exiting with success. Signed-off-by: Bernat Gabor <[email protected]>
pypa · Jul 4, 2020 · 12ad5cb · 12ad5cb
1 parent 69bed36
commit 12ad5cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/changelog/1885.bugfix.rst b/docs/changelog/1885.bugfix.rst
@@ -0,0 +1 @@
+Do not print error message if the application exists with ``SystemExit(0)`` - by :user:`gaborbernat`.
diff --git a/src/virtualenv/__main__.py b/src/virtualenv/__main__.py
@@ -66,7 +66,8 @@ def run_with_catch(args=None):
             if getattr(options, "with_traceback", False):
                 raise
             else:
-                logging.error("%s: %s", type(exception).__name__, exception)
+                if not (isinstance(exception, SystemExit) and exception.code == 0):
+                    logging.error("%s: %s", type(exception).__name__, exception)
                 code = exception.code if isinstance(exception, SystemExit) else 1
                 sys.exit(code)
         finally:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Do not print error message if the application exists with ``SystemExit(0)`` - by :user:`gaborbernat`.