Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prominently the existence of a file_finders plugin #329

Closed
apljungquist opened this issue Apr 8, 2019 · 1 comment
Closed

Document prominently the existence of a file_finders plugin #329

apljungquist opened this issue Apr 8, 2019 · 1 comment

Comments

@apljungquist
Copy link

I discovered this fact when troubleshooting files that should not have been included according to MANIFEST.in were being included.

Factoring out the feature to a separate package distribution was suggested in #190 but was rejected. Though I would have preferred a way to disable the feature, simply documenting it prominently would have saved me a lot of time.

A similar fix was attempted in #53.

The problem is somewhat aggravated by an issue with setuptools; When, in the course of figuring out why so many files where being included, I removed setuptools_scm the files were still being included.

@webknjaz
Copy link
Member

Ref: #190 (comment)

vanschelven added a commit to vanschelven/setuptools_scm that referenced this issue Jul 19, 2019
vanschelven added a commit to vanschelven/setuptools_scm that referenced this issue Jul 19, 2019
RonnyPfannschmidt added a commit that referenced this issue Jul 19, 2019
fix #329 - document the file_finders entry point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants