Enforce new ruff rules

pyproject.toml

@@ -72,15 +72,20 @@ lint.extend-select = [
   "C9",
   "I",
   "ISC",
+  "PERF",
   "PGH",
   "PLC",
   "PLE",
   "PLW",
   "RSE",
   "RUF012",
   "RUF100",
+  "TCH",
   "W",
 ]
+lint.ignore = [
+  "PERF203",
+]
 lint.isort = { known-first-party = [
   "helpers",
   "package_info",

src/pipx/commands/common.py

@@ -452,15 +452,15 @@ def run_post_install_actions(
     expose_resources_globally("man", local_man_dir, package_metadata.man_paths, force=force)
 
     if include_dependencies:
-        for _, app_paths in package_metadata.app_paths_of_dependencies.items():
+        for app_paths in package_metadata.app_paths_of_dependencies.values():
             expose_resources_globally(
                 "app",
                 local_bin_dir,
                 app_paths,
                 force=force,
                 suffix=package_metadata.suffix,
             )
-        for _, man_paths in package_metadata.man_paths_of_dependencies.items():
+        for man_paths in package_metadata.man_paths_of_dependencies.values():
             expose_resources_globally("man", local_man_dir, man_paths, force=force)
 
     package_summary, _ = get_venv_summary(venv_dir, package_name=package_name, new_install=True)

src/pipx/commands/uninstall.py

@@ -1,8 +1,10 @@
 import logging
-from collections.abc import Callable
 from pathlib import Path
 from shutil import which
-from typing import List, Optional, Set
+from typing import TYPE_CHECKING, List, Optional, Set
+
+if TYPE_CHECKING:
+    from collections.abc import Callable
 
 from pipx.commands.common import (
     add_suffix,

src/pipx/commands/upgrade.py

@@ -68,15 +68,15 @@ def _upgrade_package(
         expose_resources_globally("man", paths.ctx.man_dir, package_metadata.man_paths, force=force)
 
     if package_metadata.include_dependencies:
-        for _, app_paths in package_metadata.app_paths_of_dependencies.items():
+        for app_paths in package_metadata.app_paths_of_dependencies.values():
             expose_resources_globally(
                 "app",
                 paths.ctx.bin_dir,
                 app_paths,
                 force=force,
                 suffix=package_metadata.suffix,
             )
-        for _, man_paths in package_metadata.man_paths_of_dependencies.items():
+        for man_paths in package_metadata.man_paths_of_dependencies.values():
             expose_resources_globally("man", paths.ctx.man_dir, man_paths, force=force)
 
     if old_version == new_version:

src/pipx/venv.py

@@ -4,8 +4,10 @@
 import shutil
 import time
 from pathlib import Path
-from subprocess import CompletedProcess
-from typing import Dict, Generator, List, NoReturn, Optional, Set
+from typing import TYPE_CHECKING, Dict, Generator, List, NoReturn, Optional, Set
+
+if TYPE_CHECKING:
+    from subprocess import CompletedProcess
 
 try:
     from importlib.metadata import Distribution, EntryPoint