Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce new ruff rules #1469

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Enforce new ruff rules #1469

merged 4 commits into from
Jul 8, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

  • Enforce ruff/Perflint rules PERF
    For now, leave out this rule:
    PERF203 `try`-`except` within a loop incurs performance overhead
  • Enforce ruff/flake8-type-checking rules TCH

Test plan

CI tests.

PERF102 When using only the values of a dict use the `values()` method
For now, leave out this rule:
PERF203 `try`-`except` within a loop incurs performance overhead
CH003 Move standard library import `...` into a type-checking block
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit c9d31a6 into pypa:main Jul 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants