Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the PIP_CLIENT_CERT value when creating the requests session. #5761

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

matteius
Copy link
Member

Fixes #5746

The issue

When we introduced the pep508 package index url checks for determining package hashes, it broke users that rely on client side certificates when locking.

The fix

Consider how the users were supplying client side certs with PIP_CLIENT_CERT and pass it to the requests session as well.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 June 30, 2023 06:03
@matteius matteius merged commit 2e73f76 into main Jul 1, 2023
@matteius matteius deleted the issue-5746-patch branch July 1, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client certificates broken since 2023.6.2
1 participant