-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client certificates broken since 2023.6.2 #5746
Comments
Have you checked with |
Yes, I started with 2023.6.18 and went backwards until I found a working version. I just retried with 2023.6.18 and it does seem that version does not have the issue with verify_ssl, but the client certificate is not being used. |
@kaptajnen Does this only affect the lock phase, as in the sync phase still works with the client certs? |
I'm not seeing any changes specifically between |
It appears it only affects the lock phase. I tested by manually uninstall a dependency |
I believe its related to this change, but I am not sure what the correct way to detect the client side certificate and put it to use is. https://github.com/pypa/pipenv/pull/5701/files |
I was just about to post the same link. It looks like previous versions would only get hashes using that code, when the official pypi repository was used. Requests has a |
@kaptajnen I see the pip docs mention a |
|
@kaptajnen I just opened a patch PR but I don't have a great way of verifying it -- if you could install the linked branch |
I see this already went out. I just tested with the latest version (2023.7.4) and it is working. Thanks! |
Issue description
Since version 2023.6.2, pipenv no longer works with repositories requiring the use of client certificate authentication. Even when supplying the PIP_CLIENT_CERT environment variable, I am getting certificate errors when running e.g.
pipenv lock -d
. Furthermore, it appears the verify_ssl option in the Pipfile is ignored. I had to add the REQUESTS_CA_BUNDLE environment variable to fix this, but I assume this should be considered a bug as well.Expected result
No errors
Actual result
Steps to replicate
Not sure how you can test this if you don't have a python package repository testing environment with client certificate auth.
$ pipenv --support
Pipenv version:
'2023.6.2'
Pipenv location:
'/Users/jlaursen/.local/lib/python3.8/site-packages/pipenv'
Python location:
'/Users/jlaursen/.pyenv/versions/3.8.7/bin/python3.8'
OS Name:
'posix'
User pip version:
'20.2.3'
user Python installations found:
PEP 508 Information:
System environment variables:
PWD
PYENV_ROOT
fish_user_paths
LOGNAME
SHELL
__CFBundleIdentifier
SECURITYSESSIONID
LaunchInstanceID
ALACRITTY_WINDOW_ID
WINDOWID
HOME
__CF_USER_TEXT_ENCODING
XPC_SERVICE_NAME
PATH
OLDPWD
XPC_FLAGS
ALACRITTY_LOG
VIRTUAL_ENV_DISABLE_PROMPT
TERM
TMPDIR
EDITOR
COLORTERM
LC_ALL
ALACRITTY_SOCKET
COMMAND_MODE
SHLVL
SSH_AUTH_SOCK
USER
P4CONFIG
PYENV_SHELL
PIP_DISABLE_PIP_VERSION_CHECK
PIP_PYTHON_PATH
PYTHONDONTWRITEBYTECODE
PIP_CLIENT_CERT
REQUESTS_CA_BUNDLE
PYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
Debug–specific environment variables:
PATH
:/Users/jlaursen/.pyenv/versions/3.8.7/bin:/Users/jlaursen/.pyenv/versions/3.8.2/bin:/Users/jlaursen/.pyenv/versions/3.9.9/bin:/Users/jlaursen/.pyenv/versions/2.7.18/bin:/Users/jlaursen/Applications/google-cloud-sdk/bin:/Users/jlaursen/.pyenv/shims:/Users/jlaursen/.poetry/bin:/Users/jlaursen/workspace/octo/bin:/Users/jlaursen/.pyenv/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/usr/local/munki:/Users/jlaursen/.local/bin
SHELL
:/usr/local/bin/fish
EDITOR
:subl -w
PWD
:/Users/jlaursen/<REDACTED>/pipenvtest
Contents of
Pipfile
('/Users/jlaursen//pipenvtest/Pipfile'):Contents of
Pipfile.lock
('/Users/jlaursen//pipenvtest/Pipfile.lock'):The text was updated successfully, but these errors were encountered: