Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete typing of docs directory #9672

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Complete typing of docs directory #9672

merged 1 commit into from
Mar 26, 2021

Conversation

jdufresne
Copy link
Contributor

No description provided.

@uranusjr
Copy link
Member

What’s the reason behind removing the empty containers in conf.py? To avoid typing them?

@jdufresne
Copy link
Contributor Author

Yes, exactly right. These options are effectively unused, so we can fallback to the Sphinx defaults which avoids the need to type the empty containers. It also reduces the overall size of conf.py which is a small win, IMO.

If the preference is to type the empty options, please let em know and I'll happily add them back with types. Either way works fo rme.

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Mar 4, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 6, 2021
@pradyunsg
Copy link
Member

Closing since #9693 did this. :)

@pradyunsg pradyunsg closed this Mar 6, 2021
@jdufresne
Copy link
Contributor Author

It doesn't look that way to me. The docs directory is still excluded by mypy:

exclude: docs|tests

Is there a chance you're mixing this up with the Black PR #9671 ?

@pradyunsg
Copy link
Member

Yes I am. :)

@pradyunsg pradyunsg reopened this Mar 6, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 6, 2021
@jdufresne
Copy link
Contributor Author

Rebased to resolve conflicts 🙂

@pradyunsg pradyunsg merged commit bcbfbaa into pypa:master Mar 26, 2021
@jdufresne jdufresne deleted the mypy-docs branch August 2, 2021 15:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants