Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation rewrite (Q1 2021) #9474

Closed
wants to merge 32 commits into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jan 19, 2021

See #9475 for context and the overall idea here.


PS: If you're reviewing this, I'd say, either look at the PR preview or go commit-by-commit. Looking at the total diff will be painful.

@pradyunsg pradyunsg added the type: docs Documentation related label Jan 19, 2021
@pradyunsg
Copy link
Member Author

Oh, and you can probably see this in the RTD preview -- my rough plan for the hierarchy/structure is:

- Getting Started
- Explanations
  # topical descriptions of how stuff works, like Configuration, Authentication etc
  ...
- Reference
  # "raw" information about formats/interfaces that pip defines/how it uses them
  - Requirements Files
  - Constraint Files
  - Build System Interfaces
  # more?
- Commands
  # CLI information -- pure reference stuff with simplified descriptions
  ...
- Project Management
  # for communicating about "how and _why_ we do things" to downstream/end users
  - release
  - deprecation / change management info
  - vendoring
- Changelog

**TROUBLESHOOTING**

- Common Errors
- FAQ

**CONTRIBUTING**

- Development
  # written by pip's maintainers, for pip's contributors
  - Workflow
  - Issues
  - Pull Requests
  - Communication
- Architecture
  # implementation details and stuff
  ...
- Maintainance
  # written by pip's maintainers, for pip's maintainers
  - Change Management
  - Release Management
  - Team
UX research and design
  # UX Recommendations
  # And research summaries/descriptions in a sub-tree of "past research"
  # This will probably become a section, but I'll defer to the experts on this. :)

@pypa-bot
Copy link

pypa-bot commented Feb 4, 2021

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 22, 2021
@pradyunsg
Copy link
Member Author

@pypa/pip-committers this seems like it's gonna a big PR, so it'd be nice if someone could start reviewing this incrementally, since... There's a lot here and I don't know of any way to do this in smaller chunks.

Ideas for breaking this up into smaller chunks are super welcome. :)

@uranusjr
Copy link
Member

In the Getting Started page, it’s probably better to

  1. Add a visible block declaring pip only works with Python 3.6+
  2. Rewrite the “pip is already installed if you are” part fo remove “modern” and “>= 3.5” (because that’s implied for all pip installations now)

@uranusjr
Copy link
Member

Or, if you don’t mind more conflicts, I can just propose them separately to the current documentation 🙂

pip supports loading credentials from a user's `.netrc` file. If no credentials
are part of the URL, pip will attempt to get authentication credentials for the
URL's hostname from the user's `.netrc` file. This behaviour comes from the
underlying use of [`requests`][pypi-requests], which in turn delegates it to
Copy link
Member

@uranusjr uranusjr Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems broken

Screenshot 2021-02-24 at 18 51 43

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I never added the link. :)

@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 3, 2021
@m-aciek
Copy link

m-aciek commented Mar 4, 2021

Ad. repeatable installs chapter: In my opinion it would be worth to add a note box saying that updating dependency in a "pip frozen" environment can be a pain, because requirements.txt file lacks information which dependency is top-level and which is not. And for such use cases pip-tools and other dependency managers are preferred.

@pradyunsg
Copy link
Member Author

I've broken out #9693 from this PR, to make it easier to separate the "scaffolding changes" from the "content changes".

I'm thinking of ways to make it possible for us to incrementally switch between these structures, but more on that in follow up PRs! :)

@pradyunsg
Copy link
Member Author

pradyunsg commented Mar 6, 2021

Dumping this here, because I can't think of a better place ATM:

* d661b1411 (documentation-rewrite-1) Move constraint files stuff
* 4a3f1f533 Move compatibility information to getting-started
* 6fa46fd17 Tweak sentence in authentication explainer
* 1df09be3f :newspaper:
* df5a856cb Add dedicated page on how configuration works
* 006c9384a Capitalise all headings
* 2b84b1aa9 Add explanation page for custom install options
* 01f5528bb Add dedicated page for Requirements File format
* 9b1be27f9 Add dedicated page for VCS support
* be1f1e9a0 Add dedicated page for User Installs
* a4e7291d4 Add dedicated page for Requirements Files
* 49c46ff6f Add dedicated page for Repeatable Installs
* ef9e07cf1 Add dedicated page for editable installs
* cb88f77cd Add dedicated page for Configuration
* 6179dfe0c Add dedicated page for Caching
* 3164397d4 Add dedicated page for authentication
* c34ae86eb Change news to Markdown


pick 175b49b20 Add new documentation skeleton
pick cedd33372 Drop the troubleshooting section for new skeleton
pick a44b0cd80 Drop old .rst files overlapping with new skeleton
pick 92766ba7c Rename docs/html/{reference -> cli}
pick 300d4c2f1 Populate the new Getting Started page
pick be0bc7e14 Point to the PyPUG tutorial from quickstart

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 6, 2021
```

A requirements file, containing pinned package versions can be generated using
{ref}`pip freeze`. This would not only the top-level packages, but also all of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence lacks a predicate.

@pradyunsg
Copy link
Member Author

Closing this out, since this is being broken up into smaller chunks, as part of #9475. :)

@pradyunsg pradyunsg closed this Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants