Fix uninstallation of user scripts #8733

DaanDeMeyer · 2020-08-08T15:26:43Z

User scripts are installed to ~/.local/bin. pip was looking for scripts
to uninstall in ~/.local/lib/python3.8/site-packages/bin. This commit
makes it look in ~/.local/bin instead.

Fixes the reproducer reported in #5997.

Might break other use cases, I'm not familiar with pip at all. Will hapilly take guidance on the correct way to fix this.

behrmann · 2020-08-08T15:32:33Z

I think this might brake the virtual environment usecase, as in a venv getuserbase() still evaluates to ~/.local/bin

DaanDeMeyer · 2020-08-08T15:38:09Z

Gated the fix behind a running_in_virtualenv() check.

src/pip/_internal/locations.py

uranusjr · 2020-08-08T15:42:53Z

This feels hacky to me. Maybe we should rewrite the location detection stuff with sysconfig instead, which should return the correct scheme.

behrmann · 2020-08-08T15:48:24Z

Indeed, sysconfig.get_path("scripts") would return the proper path.

behrmann · 2020-08-08T15:51:59Z

Since site only seems to be used for the script related paths, all these paths could just be exchanged for sysconfig.get_path("scripts") and site would not be needed anymore.

src/pip/_internal/locations.py

DaanDeMeyer · 2020-08-08T16:13:29Z

Not sure how to fix the CI failure. I guess we need a fallback if get_path("scripts") fails but I'm not sure what that would be.

uranusjr · 2020-08-08T17:14:08Z

A simple assert bin_dir is not None would be fine. sysconfig.get_path() never returns None unless you pass in an invalid key. 'scripts' always exists.

src/pip/_internal/locations.py

news/8733.bugfix

src/pip/_internal/locations.py

src/pip/_internal/req/req_uninstall.py

src/pip/_internal/locations.py

User scripts are installed to ~/.local/bin. pip was looking for scripts to uninstall in ~/.local/lib/python3.8/site-packages/bin. This commit makes it look in ~/.local/bin instead.

DaanDeMeyer · 2020-09-04T22:45:05Z

@uranusjr All the tests are passing now.

One annoying thing is that this only fixes console_scripts and not normal scripts. Any ideas on how to fix that as well?

uranusjr · 2020-09-10T05:24:50Z

IIUC, plain scripts (specified by setuptools scripts) is hopeless since they are not recorded anywhere for editable installs, and pip has no way to know what to uninstall. The only way to fix this would be to “modernise” editable installations to use .dist-info metadata. There are efforts toward this, but they are out of the scope for this PR.

src/pip/_internal/locations.py

Co-authored-by: Tzu-ping Chung <[email protected]>

pradyunsg

Seems OK to me! If you could tweak the NEWS fragment, I'll be happy to merge this in!

I'll defer to @uranusjr's judgement of whether the Windows-specific logic is correct. :)

news/8733.bugfix

uranusjr · 2021-02-18T10:07:57Z

This can be merged once the suggested change to the news fragment is applied.

Co-authored-by: Pradyun Gedam <[email protected]>

uranusjr · 2021-02-25T12:11:12Z

Weigh anchor, we’re going for a ride!

Bumps [pip](https://github.com/pypa/pip) from 21.0.1 to 21.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>21.1 (2021-04-24)</h1> <h2>Process</h2> <ul> <li>Start installation scheme migration from <code>distutils</code> to <code>sysconfig</code>. A warning is implemented to detect differences between the two implementations to encourage user reports, so we can avoid breakages before they happen.</li> </ul> <h2>Features</h2> <ul> <li>Add the ability for the new resolver to process URL constraints. (<code>[#8253](pypa/pip#8253) <https://github.com/pypa/pip/issues/8253></code>_)</li> <li>Add a feature <code>--use-feature=in-tree-build</code> to build local projects in-place when installing. This is expected to become the default behavior in pip 21.3; see <code>Installing from local packages <https://pip.pypa.io/en/stable/user_guide/#installing-from-local-packages></code>_ for more information. (<code>[#9091](pypa/pip#9091) <https://github.com/pypa/pip/issues/9091></code>_)</li> <li>Bring back the "(from versions: ...)" message, that was shown on resolution failures. (<code>[#9139](pypa/pip#9139) <https://github.com/pypa/pip/issues/9139></code>_)</li> <li>Add support for editable installs for project with only setup.cfg files. (<code>[#9547](pypa/pip#9547) <https://github.com/pypa/pip/issues/9547></code>_)</li> <li>Improve performance when picking the best file from indexes during <code>pip install</code>. (<code>[#9748](pypa/pip#9748) <https://github.com/pypa/pip/issues/9748></code>_)</li> <li>Warn instead of erroring out when doing a PEP 517 build in presence of <code>--build-option</code>. Warn when doing a PEP 517 build in presence of <code>--global-option</code>. (<code>[#9774](pypa/pip#9774) <https://github.com/pypa/pip/issues/9774></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Fixed <code>--target</code> to work with <code>--editable</code> installs. (<code>[#4390](pypa/pip#4390) <https://github.com/pypa/pip/issues/4390></code>_)</li> <li>Add a warning, discouraging the usage of pip as root, outside a virtual environment. (<code>[#6409](pypa/pip#6409) <https://github.com/pypa/pip/issues/6409></code>_)</li> <li>Ignore <code>.dist-info</code> directories if the stem is not a valid Python distribution name, so they don't show up in e.g. <code>pip freeze</code>. (<code>[#7269](pypa/pip#7269) <https://github.com/pypa/pip/issues/7269></code>_)</li> <li>Only query the keyring for URLs that actually trigger error 401. This prevents an unnecessary keyring unlock prompt on every pip install invocation (even with default index URL which is not password protected). (<code>[#8090](pypa/pip#8090) <https://github.com/pypa/pip/issues/8090></code>_)</li> <li>Prevent packages already-installed alongside with pip to be injected into an isolated build environment during build-time dependency population. (<code>[#8214](pypa/pip#8214) <https://github.com/pypa/pip/issues/8214></code>_)</li> <li>Fix <code>pip freeze</code> permission denied error in order to display an understandable error message and offer solutions. (<code>[#8418](pypa/pip#8418) <https://github.com/pypa/pip/issues/8418></code>_)</li> <li>Correctly uninstall script files (from setuptools' <code>scripts</code> argument), when installed with <code>--user</code>. (<code>[#8733](pypa/pip#8733) <https://github.com/pypa/pip/issues/8733></code>_)</li> <li>New resolver: When a requirement is requested both via a direct URL (<code>req @ URL</code>) and via version specifier with extras (<code>req[extra]</code>), the resolver will now be able to use the URL to correctly resolve the requirement with extras. (<code>[#8785](pypa/pip#8785) <https://github.com/pypa/pip/issues/8785></code>_)</li> <li>New resolver: Show relevant entries from user-supplied constraint files in the error message to improve debuggability. (<code>[#9300](pypa/pip#9300) <https://github.com/pypa/pip/issues/9300></code>_)</li> <li>Avoid parsing version to make the version check more robust against lousily debundled downstream distributions. (<code>[#9348](pypa/pip#9348) <https://github.com/pypa/pip/issues/9348></code>_)</li> <li><code>--user</code> is no longer suggested incorrectly when pip fails with a permission error in a virtual environment. (<code>[#9409](pypa/pip#9409) <https://github.com/pypa/pip/issues/9409></code>_)</li> <li>Fix incorrect reporting on <code>Requires-Python</code> conflicts. (<code>[#9541](pypa/pip#9541) <https://github.com/pypa/pip/issues/9541></code>_)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/2b2a268d25963727c2a1c805de8f0246b9cd63f6"><code>2b2a268</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ea761a6575f37b90cf89035ee8be3808cf872184"><code>ea761a6</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/2edd3fdf2af2f09dce5085ef0eb54684b4f9bc04"><code>2edd3fd</code></a> Postpone a deprecation to 21.2</li> <li><a href="https://github.com/pypa/pip/commit/3cccfbf169bd35133ee25d2543659b9c1e262f8c"><code>3cccfbf</code></a> Rename mislabeled news fragment</li> <li><a href="https://github.com/pypa/pip/commit/21cd124b5d40b510295c201b9152a65ac3337a37"><code>21cd124</code></a> Fix NEWS.rst placeholder position</li> <li><a href="https://github.com/pypa/pip/commit/e46bdda9711392fec0c45c1175bae6db847cb30b"><code>e46bdda</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9827">#9827</a> from pradyunsg/fix-git-improper-tag-handling</li> <li><a href="https://github.com/pypa/pip/commit/0e4938d269815a5bf1dd8c16e851cb1199fc5317"><code>0e4938d</code></a> 📰</li> <li><a href="https://github.com/pypa/pip/commit/ca832b2836e0bffa7cf95589acdcd71230f5834e"><code>ca832b2</code></a> Don't split git references on unicode separators</li> <li><a href="https://github.com/pypa/pip/commit/1320bac4ff80d76b8fba2c8b4b4614a40fb9c6c3"><code>1320bac</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9814">#9814</a> from pradyunsg/revamp-ci-apr-2021-v2</li> <li><a href="https://github.com/pypa/pip/commit/e9cc23ffd97cb6d66d32dc3ec27cf832524bb33d"><code>e9cc23f</code></a> Skip checks on PRs only</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/21.0.1...21.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=21.0.1&new-version=21.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

DaanDeMeyer force-pushed the fix-local-script-uninstall branch 2 times, most recently from 07754fc to 56e85d0 Compare August 8, 2020 15:28

DaanDeMeyer force-pushed the fix-local-script-uninstall branch from 56e85d0 to 781108f Compare August 8, 2020 15:37

behrmann reviewed Aug 8, 2020

View reviewed changes

src/pip/_internal/locations.py Outdated Show resolved Hide resolved

DaanDeMeyer force-pushed the fix-local-script-uninstall branch 2 times, most recently from 4fad37f to 7b7b669 Compare August 8, 2020 15:57

behrmann reviewed Aug 8, 2020

View reviewed changes

src/pip/_internal/locations.py Outdated Show resolved Hide resolved

pypa deleted a comment from DaanDeMeyer Aug 8, 2020

behrmann reviewed Aug 8, 2020

View reviewed changes

src/pip/_internal/locations.py Show resolved Hide resolved

DaanDeMeyer force-pushed the fix-local-script-uninstall branch 2 times, most recently from cfe82ea to e8b1614 Compare August 8, 2020 17:19

uranusjr requested changes Aug 8, 2020

View reviewed changes

src/pip/_internal/locations.py Outdated Show resolved Hide resolved

news/8733.bugfix Outdated Show resolved Hide resolved

src/pip/_internal/locations.py Show resolved Hide resolved

DaanDeMeyer force-pushed the fix-local-script-uninstall branch from e8b1614 to 6330493 Compare August 8, 2020 19:24

uranusjr reviewed Aug 8, 2020

View reviewed changes

src/pip/_internal/req/req_uninstall.py Outdated Show resolved Hide resolved

uranusjr reviewed Aug 8, 2020

View reviewed changes

src/pip/_internal/locations.py Outdated Show resolved Hide resolved

DaanDeMeyer force-pushed the fix-local-script-uninstall branch from 6330493 to fa84038 Compare August 25, 2020 18:58

DaanDeMeyer force-pushed the fix-local-script-uninstall branch 5 times, most recently from e3b6baa to 7d9be73 Compare September 4, 2020 21:18

Fix uninstallation of user scripts

7d9be73

User scripts are installed to ~/.local/bin. pip was looking for scripts to uninstall in ~/.local/lib/python3.8/site-packages/bin. This commit makes it look in ~/.local/bin instead.

uranusjr approved these changes Sep 10, 2020

View reviewed changes

uranusjr reviewed Sep 10, 2020

View reviewed changes

src/pip/_internal/locations.py Outdated Show resolved Hide resolved

Simplify type annotation

0ecbce2

Co-authored-by: Tzu-ping Chung <[email protected]>

pradyunsg added the type: bugfix label Sep 10, 2020

pradyunsg approved these changes Sep 10, 2020

View reviewed changes

news/8733.bugfix Outdated Show resolved Hide resolved

uranusjr and others added 2 commits February 25, 2021 13:59

Update news fragment from review suggestions

3932c31

Co-authored-by: Pradyun Gedam <[email protected]>

Add .rst suffix to news fragment

c63e5d3

uranusjr mentioned this pull request Feb 25, 2021

Implement sysconfig-based location inference #9626

Merged

uranusjr merged commit 410e82a into pypa:master Feb 25, 2021

github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix uninstallation of user scripts #8733

Fix uninstallation of user scripts #8733

DaanDeMeyer commented Aug 8, 2020 •

edited

Loading

behrmann commented Aug 8, 2020

DaanDeMeyer commented Aug 8, 2020

uranusjr commented Aug 8, 2020 •

edited

Loading

behrmann commented Aug 8, 2020

behrmann commented Aug 8, 2020

DaanDeMeyer commented Aug 8, 2020

uranusjr commented Aug 8, 2020

DaanDeMeyer commented Sep 4, 2020

uranusjr commented Sep 10, 2020

pradyunsg left a comment

uranusjr commented Feb 18, 2021

uranusjr commented Feb 25, 2021 •

edited

Loading

Fix uninstallation of user scripts #8733

Fix uninstallation of user scripts #8733

Conversation

DaanDeMeyer commented Aug 8, 2020 • edited Loading

behrmann commented Aug 8, 2020

DaanDeMeyer commented Aug 8, 2020

uranusjr commented Aug 8, 2020 • edited Loading

behrmann commented Aug 8, 2020

behrmann commented Aug 8, 2020

DaanDeMeyer commented Aug 8, 2020

uranusjr commented Aug 8, 2020

DaanDeMeyer commented Sep 4, 2020

uranusjr commented Sep 10, 2020

pradyunsg left a comment

Choose a reason for hiding this comment

uranusjr commented Feb 18, 2021

uranusjr commented Feb 25, 2021 • edited Loading

DaanDeMeyer commented Aug 8, 2020 •

edited

Loading

uranusjr commented Aug 8, 2020 •

edited

Loading

uranusjr commented Feb 25, 2021 •

edited

Loading