Fixed development install for setuptools projects without setup.py #9547

KOLANICH · 2021-02-01T10:33:41Z

No description provided.

src/pip/_internal/utils/setuptools_build.py

pradyunsg

I'm on board for the idea, not the exact implementation here.

news/9547.bugfix.rst

src/pip/_internal/utils/setuptools_build.py

uranusjr

Logic lgtm. Would it be possible to create a test for this?

Also lint errors need to be fixed.

KOLANICH · 2021-02-19T12:56:32Z

@uranusjr Sorry, the test I have added doesn't work (IDK why) and the tests cannot be run on a local machine, (in fact they run, but incorrectly: all of them fail with AssertionError: []). I am not going to work on them anymore.

The lint errors are fixed, feel free to fix the tests yourself.

uranusjr · 2021-02-23T13:05:34Z

I’ve sent a PR to your fork. The changes should reflect here once it’s merged.

uranusjr · 2021-02-23T14:21:42Z

It seems like there are a couple more failures on message differences.

FAILED tests/functional/test_install.py::test_editable_install__local_dir_no_setup_py_with_pyproject
FAILED tests/functional/test_install.py::test_editable_install__local_dir_no_setup_py

Both are failing on something like

assert msg.startswith('ERROR: File "setup.py" not found. ')

while msg is

ERROR: File "setup.py" or "setup.cfg" not found.

pradyunsg · 2021-02-23T18:51:25Z

news/9547.bugfix.rst

@@ -0,0 +1 @@
+Fixed the bug preventing the use of --editable installs for setup.cfg-only setuptools-based projects.


Suggestion: change this to a .feature.rst file, and change the content to: Add support for editable installs for project with only setup.cfg files.

That’ll make it more discoverable and most users (and I) would consider this a new feature.

IMHO it is not quite a new feature, I was expecting that if setuptools understands setup.cfg-only projects, that pip would understand them too automatically, but it turned out that pip uses setuptools in a bit own way. I feel like the most of people that encountered this issue were originally assumming that it would work and were surprised that it doesn't. So, it looks more like a bug, than a feature.

I understand this is a bugfix from the technical perspective, but in practice, very few user expected pip install -e to work on a setup.py-less project before this change, and most would feel it is more like a new feature instead. The changelog is ultimately consumed mostly by people not faimilar with pip internals, so it’s probably better to mark this as a feature.

BrownTruck · 2021-02-28T22:01:06Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

uranusjr · 2021-03-02T21:53:23Z

@KOLANICH Would you be able to fix the test errors described in my above comment #9547 (comment)? The fixes should not be too difficult to apply even without running the test suite locally, and I think this is ready once they pass.

KOLANICH · 2021-03-02T23:28:44Z

BTW, while doing this PR I saw a lot of os.path instead of pathlib.Path. Should they be replaced (in other PRs), or not?

uranusjr · 2021-03-03T09:21:40Z

Feel free to replace them if you feel like it (as long as you keep the changes bite-size), they are just there for historical reasons.

Co-Authored-By: Tzu-ping Chung <[email protected]> Co-Authored-By: Pradyun Gedam <[email protected]>

RonnyPfannschmidt

I love where this is going

pfmoore

I'm not entirely sure I'm comfortable with a setuptools-based project without a setup.py as a general concept (I don't want people to think that pip is the front end for setuptools, and start asking for pip sdist to replace setup.py sdist for example) but that's a problem for setuptools to manage, and doesn't really affect this PR, which looks OK on its own merits.

henryiii · 2021-04-22T14:51:31Z

python -m build --sdist or pipx run build --sdist replaces python setup.py sdist.

Bumps [pip](https://github.com/pypa/pip) from 21.0.1 to 21.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>21.1 (2021-04-24)</h1> <h2>Process</h2> <ul> <li>Start installation scheme migration from <code>distutils</code> to <code>sysconfig</code>. A warning is implemented to detect differences between the two implementations to encourage user reports, so we can avoid breakages before they happen.</li> </ul> <h2>Features</h2> <ul> <li>Add the ability for the new resolver to process URL constraints. (<code>[#8253](pypa/pip#8253) <https://github.com/pypa/pip/issues/8253></code>_)</li> <li>Add a feature <code>--use-feature=in-tree-build</code> to build local projects in-place when installing. This is expected to become the default behavior in pip 21.3; see <code>Installing from local packages <https://pip.pypa.io/en/stable/user_guide/#installing-from-local-packages></code>_ for more information. (<code>[#9091](pypa/pip#9091) <https://github.com/pypa/pip/issues/9091></code>_)</li> <li>Bring back the "(from versions: ...)" message, that was shown on resolution failures. (<code>[#9139](pypa/pip#9139) <https://github.com/pypa/pip/issues/9139></code>_)</li> <li>Add support for editable installs for project with only setup.cfg files. (<code>[#9547](pypa/pip#9547) <https://github.com/pypa/pip/issues/9547></code>_)</li> <li>Improve performance when picking the best file from indexes during <code>pip install</code>. (<code>[#9748](pypa/pip#9748) <https://github.com/pypa/pip/issues/9748></code>_)</li> <li>Warn instead of erroring out when doing a PEP 517 build in presence of <code>--build-option</code>. Warn when doing a PEP 517 build in presence of <code>--global-option</code>. (<code>[#9774](pypa/pip#9774) <https://github.com/pypa/pip/issues/9774></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Fixed <code>--target</code> to work with <code>--editable</code> installs. (<code>[#4390](pypa/pip#4390) <https://github.com/pypa/pip/issues/4390></code>_)</li> <li>Add a warning, discouraging the usage of pip as root, outside a virtual environment. (<code>[#6409](pypa/pip#6409) <https://github.com/pypa/pip/issues/6409></code>_)</li> <li>Ignore <code>.dist-info</code> directories if the stem is not a valid Python distribution name, so they don't show up in e.g. <code>pip freeze</code>. (<code>[#7269](pypa/pip#7269) <https://github.com/pypa/pip/issues/7269></code>_)</li> <li>Only query the keyring for URLs that actually trigger error 401. This prevents an unnecessary keyring unlock prompt on every pip install invocation (even with default index URL which is not password protected). (<code>[#8090](pypa/pip#8090) <https://github.com/pypa/pip/issues/8090></code>_)</li> <li>Prevent packages already-installed alongside with pip to be injected into an isolated build environment during build-time dependency population. (<code>[#8214](pypa/pip#8214) <https://github.com/pypa/pip/issues/8214></code>_)</li> <li>Fix <code>pip freeze</code> permission denied error in order to display an understandable error message and offer solutions. (<code>[#8418](pypa/pip#8418) <https://github.com/pypa/pip/issues/8418></code>_)</li> <li>Correctly uninstall script files (from setuptools' <code>scripts</code> argument), when installed with <code>--user</code>. (<code>[#8733](pypa/pip#8733) <https://github.com/pypa/pip/issues/8733></code>_)</li> <li>New resolver: When a requirement is requested both via a direct URL (<code>req @ URL</code>) and via version specifier with extras (<code>req[extra]</code>), the resolver will now be able to use the URL to correctly resolve the requirement with extras. (<code>[#8785](pypa/pip#8785) <https://github.com/pypa/pip/issues/8785></code>_)</li> <li>New resolver: Show relevant entries from user-supplied constraint files in the error message to improve debuggability. (<code>[#9300](pypa/pip#9300) <https://github.com/pypa/pip/issues/9300></code>_)</li> <li>Avoid parsing version to make the version check more robust against lousily debundled downstream distributions. (<code>[#9348](pypa/pip#9348) <https://github.com/pypa/pip/issues/9348></code>_)</li> <li><code>--user</code> is no longer suggested incorrectly when pip fails with a permission error in a virtual environment. (<code>[#9409](pypa/pip#9409) <https://github.com/pypa/pip/issues/9409></code>_)</li> <li>Fix incorrect reporting on <code>Requires-Python</code> conflicts. (<code>[#9541](pypa/pip#9541) <https://github.com/pypa/pip/issues/9541></code>_)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/2b2a268d25963727c2a1c805de8f0246b9cd63f6"><code>2b2a268</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ea761a6575f37b90cf89035ee8be3808cf872184"><code>ea761a6</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/2edd3fdf2af2f09dce5085ef0eb54684b4f9bc04"><code>2edd3fd</code></a> Postpone a deprecation to 21.2</li> <li><a href="https://github.com/pypa/pip/commit/3cccfbf169bd35133ee25d2543659b9c1e262f8c"><code>3cccfbf</code></a> Rename mislabeled news fragment</li> <li><a href="https://github.com/pypa/pip/commit/21cd124b5d40b510295c201b9152a65ac3337a37"><code>21cd124</code></a> Fix NEWS.rst placeholder position</li> <li><a href="https://github.com/pypa/pip/commit/e46bdda9711392fec0c45c1175bae6db847cb30b"><code>e46bdda</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9827">#9827</a> from pradyunsg/fix-git-improper-tag-handling</li> <li><a href="https://github.com/pypa/pip/commit/0e4938d269815a5bf1dd8c16e851cb1199fc5317"><code>0e4938d</code></a> 📰</li> <li><a href="https://github.com/pypa/pip/commit/ca832b2836e0bffa7cf95589acdcd71230f5834e"><code>ca832b2</code></a> Don't split git references on unicode separators</li> <li><a href="https://github.com/pypa/pip/commit/1320bac4ff80d76b8fba2c8b4b4614a40fb9c6c3"><code>1320bac</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9814">#9814</a> from pradyunsg/revamp-ci-apr-2021-v2</li> <li><a href="https://github.com/pypa/pip/commit/e9cc23ffd97cb6d66d32dc3ec27cf832524bb33d"><code>e9cc23f</code></a> Skip checks on PRs only</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/21.0.1...21.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=21.0.1&new-version=21.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

Bumps [pip](https://github.com/pypa/pip) from 21.0.1 to 21.1.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>21.1.1 (2021-04-30)</h1> <h2>Deprecations and Removals</h2> <ul> <li>Temporarily set the new "Value for ... does not match" location warnings level to <em>DEBUG</em>, to hide them from casual users. This prepares pip 21.1 for CPython inclusion, while pip maintainers digest the first intake of location mismatch issues for the <code>distutils</code>-<code>sysconfig</code> transition. (<code>[#9912](pypa/pip#9912) <https://github.com/pypa/pip/issues/9912></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>This change fixes a bug on Python `_)</li> <li>Fix compatibility between distutils and sysconfig when the project name is unknown outside of a virtual environment. (<code>[#9838](pypa/pip#9838) <https://github.com/pypa/pip/issues/9838></code>_)</li> <li>Fix Python 3.6 compatibility when a PEP 517 build requirement itself needs to be built in an isolated environment. (<code>[#9878](pypa/pip#9878) <https://github.com/pypa/pip/issues/9878></code>_)</li> </ul> <h1>21.1 (2021-04-24)</h1> <h2>Process</h2> <ul> <li>Start installation scheme migration from <code>distutils</code> to <code>sysconfig</code>. A warning is implemented to detect differences between the two implementations to encourage user reports, so we can avoid breakages before they happen.</li> </ul> <h2>Features</h2> <ul> <li>Add the ability for the new resolver to process URL constraints. (<code>[#8253](pypa/pip#8253) <https://github.com/pypa/pip/issues/8253></code>_)</li> <li>Add a feature <code>--use-feature=in-tree-build</code> to build local projects in-place when installing. This is expected to become the default behavior in pip 21.3; see <code>Installing from local packages <https://pip.pypa.io/en/stable/user_guide/#installing-from-local-packages></code>_ for more information. (<code>[#9091](pypa/pip#9091) <https://github.com/pypa/pip/issues/9091></code>_)</li> <li>Bring back the "(from versions: ...)" message, that was shown on resolution failures. (<code>[#9139](pypa/pip#9139) <https://github.com/pypa/pip/issues/9139></code>_)</li> <li>Add support for editable installs for project with only setup.cfg files. (<code>[#9547](pypa/pip#9547) <https://github.com/pypa/pip/issues/9547></code>_)</li> <li>Improve performance when picking the best file from indexes during <code>pip install</code>. (<code>[#9748](pypa/pip#9748) <https://github.com/pypa/pip/issues/9748></code>_)</li> <li>Warn instead of erroring out when doing a PEP 517 build in presence of <code>--build-option</code>. Warn when doing a PEP 517 build in presence of <code>--global-option</code>. (<code>[#9774](pypa/pip#9774) <https://github.com/pypa/pip/issues/9774></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Fixed <code>--target</code> to work with <code>--editable</code> installs. (<code>[#4390](pypa/pip#4390) <https://github.com/pypa/pip/issues/4390></code>_)</li> <li>Add a warning, discouraging the usage of pip as root, outside a virtual environment. (<code>[#6409](pypa/pip#6409) <https://github.com/pypa/pip/issues/6409></code>_)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/c53d88c4c374523425f4db6bef949090764465c0"><code>c53d88c</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/4417e7f4bef2b2c70767c1dbfe72f82cc6b7b83f"><code>4417e7f</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/0c29bfe48e650c5a428b77eba4af7f067c019cc8"><code>0c29bfe</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9912">#9912</a> from uranusjr/sysconfig-remove-warning-for-python-re...</li> <li><a href="https://github.com/pypa/pip/commit/f56ec327b92ebe836e63e07cb2449a20e09dec38"><code>f56ec32</code></a> Make location mismatch messages DEBUG level</li> <li><a href="https://github.com/pypa/pip/commit/999b121402302a00b235a0d443f5661b69d6fd60"><code>999b121</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9883">#9883</a> from uranusjr/isolated-pip-py36-compat</li> <li><a href="https://github.com/pypa/pip/commit/f88420319db450aefbed1500f04e31be46874aaf"><code>f884203</code></a> Fallback to self-invoke via directory on 3.6</li> <li><a href="https://github.com/pypa/pip/commit/7a77484a492c8f1e1f5ef24eaf71a43df9ea47eb"><code>7a77484</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9835">#9835</a> from jamescurtin/9831-bugfix</li> <li><a href="https://github.com/pypa/pip/commit/914bcc3dba88179f4e88ce90b63660474ba795cd"><code>914bcc3</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/pip/issues/9838">#9838</a> from uranusjr/sysconfig-header-with-none-project</li> <li><a href="https://github.com/pypa/pip/commit/2a009a0b8a5d8d03117897f0f11f9c1dcf2a4b5a"><code>2a009a0</code></a> Better explanatory comment</li> <li><a href="https://github.com/pypa/pip/commit/e7b1722efeaf4ff403142847ce1b52caedd5efcd"><code>e7b1722</code></a> Set dist_name to UNKNOWN when empty outside venv</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/21.0.1...21.1.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=21.0.1&new-version=21.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

KOLANICH force-pushed the setupcfg_only_devinstall branch 2 times, most recently from e0c3815 to 99b878a Compare February 1, 2021 10:38

uranusjr requested changes Feb 1, 2021

View reviewed changes

src/pip/_internal/utils/setuptools_build.py Outdated Show resolved Hide resolved

pfmoore reviewed Feb 1, 2021

View reviewed changes

src/pip/_internal/utils/setuptools_build.py Outdated Show resolved Hide resolved

pradyunsg reviewed Feb 1, 2021

View reviewed changes

news/9547.bugfix.rst Outdated Show resolved Hide resolved

src/pip/_internal/utils/setuptools_build.py Outdated Show resolved Hide resolved

src/pip/_internal/utils/setuptools_build.py Outdated Show resolved Hide resolved

KOLANICH force-pushed the setupcfg_only_devinstall branch from 99b878a to 0179d62 Compare February 1, 2021 17:59

uranusjr reviewed Feb 2, 2021

View reviewed changes

KOLANICH mentioned this pull request Feb 6, 2021

Removed setup.py, since setuptools now supports workflows with setup.cfg only jaraco/skeleton#44

Closed

KOLANICH force-pushed the setupcfg_only_devinstall branch 5 times, most recently from 9ca3542 to 0655f47 Compare February 19, 2021 11:56

uranusjr mentioned this pull request Feb 23, 2021

This should fix the test errors KOLANICH-tools/pip#1

Merged

pradyunsg reviewed Feb 23, 2021

View reviewed changes

KOLANICH force-pushed the setupcfg_only_devinstall branch from 87de0fe to 23f2d12 Compare February 24, 2021 10:58

BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 28, 2021

KOLANICH force-pushed the setupcfg_only_devinstall branch from 23f2d12 to c357510 Compare March 1, 2021 18:31

pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 1, 2021

Fixed --editable install for setuptools projects without setup.py.

7a95720

Co-Authored-By: Tzu-ping Chung <[email protected]> Co-Authored-By: Pradyun Gedam <[email protected]>

KOLANICH force-pushed the setupcfg_only_devinstall branch from bb9e258 to 7a95720 Compare March 3, 2021 18:24

RonnyPfannschmidt reviewed Mar 3, 2021

View reviewed changes

pradyunsg requested a review from uranusjr March 3, 2021 20:41

pradyunsg approved these changes Mar 3, 2021

View reviewed changes

pradyunsg requested a review from pfmoore March 3, 2021 20:41

pfmoore approved these changes Mar 3, 2021

View reviewed changes

uranusjr approved these changes Mar 4, 2021

View reviewed changes

uranusjr merged commit 3ab760a into pypa:master Mar 4, 2021

KOLANICH deleted the setupcfg_only_devinstall branch March 4, 2021 19:32

henryiii mentioned this pull request Apr 22, 2021

Removed setup.py. tomerfiliba/plumbum#546

Closed

sbidoul mentioned this pull request May 4, 2021

Confusing error when setup.py, setup.cfg and pyproject.toml are absent #9944

Closed

1 task

gtca mentioned this pull request May 20, 2021

fix installation scverse/muon#25

Merged

henryiii mentioned this pull request May 21, 2021

Contradictions/Inconsistencies between packaging tutorial and guide pypa/packaging.python.org#887

Open

pradyunsg mentioned this pull request May 26, 2021

Restore setup.cfg only packages? pypa/build#302

Closed

uranusjr mentioned this pull request Jun 19, 2021

Unify Python project root detection logic #10082

Merged

AntoineD mentioned this pull request Sep 2, 2021

usedevelop without setup.py failure tox-dev/tox#2197

Closed

github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed development install for setuptools projects without setup.py #9547

Fixed development install for setuptools projects without setup.py #9547

KOLANICH commented Feb 1, 2021

pradyunsg left a comment

uranusjr left a comment

KOLANICH commented Feb 19, 2021

uranusjr commented Feb 23, 2021

uranusjr commented Feb 23, 2021

pradyunsg Feb 23, 2021 •

edited

Loading

KOLANICH Mar 2, 2021 •

edited

Loading

uranusjr Mar 3, 2021

BrownTruck commented Feb 28, 2021

uranusjr commented Mar 2, 2021

KOLANICH commented Mar 2, 2021

uranusjr commented Mar 3, 2021

RonnyPfannschmidt left a comment

pfmoore left a comment

henryiii commented Apr 22, 2021

		@@ -0,0 +1 @@
		Fixed the bug preventing the use of --editable installs for setup.cfg-only setuptools-based projects.

Fixed development install for setuptools projects without setup.py #9547

Fixed development install for setuptools projects without setup.py #9547

Conversation

KOLANICH commented Feb 1, 2021

pradyunsg left a comment

Choose a reason for hiding this comment

uranusjr left a comment

Choose a reason for hiding this comment

KOLANICH commented Feb 19, 2021

uranusjr commented Feb 23, 2021

uranusjr commented Feb 23, 2021

pradyunsg Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

KOLANICH Mar 2, 2021 • edited Loading

Choose a reason for hiding this comment

uranusjr Mar 3, 2021

Choose a reason for hiding this comment

BrownTruck commented Feb 28, 2021

uranusjr commented Mar 2, 2021

KOLANICH commented Mar 2, 2021

uranusjr commented Mar 3, 2021

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

pfmoore left a comment

Choose a reason for hiding this comment

henryiii commented Apr 22, 2021

pradyunsg Feb 23, 2021 •

edited

Loading

KOLANICH Mar 2, 2021 •

edited

Loading