Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect deprecation warning for build_dir in tests #8481

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Expect deprecation warning for build_dir in tests #8481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/functional/test_install_cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,14 @@ def test_cleanup_prevented_upon_build_dir_exception(
'--build', build,
expect_error=(not use_new_resolver),
expect_temp=(not use_new_resolver),
expect_stderr=True,
)

assert (
"The -b/--build/--build-dir/--build-directory "
"option is deprecated."
) in result.stderr

if not use_new_resolver:
assert result.returncode == PREVIOUS_BUILD_DIR_ERROR, str(result)
assert "pip can't proceed" in result.stderr, str(result)
Expand Down
6 changes: 6 additions & 0 deletions tests/functional/test_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,14 @@ def test_pip_wheel_fail_cause_of_previous_build_dir(
'simple==3.0',
expect_error=(not use_new_resolver),
expect_temp=(not use_new_resolver),
expect_stderr=True,
)

assert (
"The -b/--build/--build-dir/--build-directory "
"option is deprecated."
) in result.stderr

# Then I see that the error code is the right one
if not use_new_resolver:
assert result.returncode == PREVIOUS_BUILD_DIR_ERROR, result
Expand Down