Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect deprecation warning for build_dir in tests #8481

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

uranusjr
Copy link
Member

The deprecation done in #8372 is failing the new resolver tests because we didn’t explicitly expect things in stderr.

This should make master green again.

@uranusjr uranusjr added C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels Jun 23, 2020
@pradyunsg pradyunsg merged commit 92c7eeb into pypa:master Jun 23, 2020
@pradyunsg
Copy link
Member

Thanks for this! ^>^

@uranusjr uranusjr deleted the warning-fixes branch June 23, 2020 13:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants