-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significantly improve release version validation #8020
Significantly improve release version validation #8020
Conversation
To general idea LGTM. I think this is good to go as long as the implementation works :p |
f43d24e
to
de633cd
Compare
What do you mean by "as long as the implementation works"? It's clearly working. 😝 |
More seriously though, how exactly did mypy not catch that? |
IIUC Mypy only typecheck if eveything function on the code path is somewhat type hinted. I bet it never reached |
Running w/ a couple of configuration options changed reveals why... nox doesn't have type annotations and we don't install it in the pre-commit environment anyway. Even though we were type-checking that function... it just assigned Any to |
Theory confirmed. :) |
Merging since I have a green tick from @uranusjr and CI. :) |
Closes #7952
Notably:
packaging
for validation, but don't want to add that as an extra release process step.