Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pre-releases to our release automation #7952

Closed
pradyunsg opened this issue Apr 1, 2020 · 3 comments · Fixed by #8020
Closed

Add support for pre-releases to our release automation #7952

pradyunsg opened this issue Apr 1, 2020 · 3 comments · Fixed by #8020
Assignees
@pradyunsg
Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc !release blocker Hold a release until this is resolved type: maintenance Related to Development and Maintenance Processes
Milestone
20.1

Comments

@pradyunsg
Copy link
Member

pradyunsg commented Apr 1, 2020 •
edited
Loading

Currently, our release automation does not permit / handle pre-release version numbers being passed as part of the CLI (you can't do nox -s prepare-release -- 20.1.b1 for example).

This would likely be important for the work being undertaken as part of https://wiki.python.org/psf/Pip2020DonorFundedRoadmap, to roll out a fix for #988.
@pradyunsg pradyunsg added C: automation Automated checks, CI etc type: maintenance Related to Development and Maintenance Processes labels Apr 1, 2020
@brainwane
Copy link
Contributor

It would be really nice if we had this -- I don't think we need to implement it IN April prior to #7951 but @pradyunsg should please tell me if I am wrong.

@pradyunsg
Copy link
Member Author

Yea. This isn't needed for 20.1, and does not affect / get affected by the release cycle.

@NoahGorny NoahGorny mentioned this issue Apr 9, 2020
Closed
@pradyunsg pradyunsg self-assigned this Apr 10, 2020
@pradyunsg pradyunsg added the !release blocker Hold a release until this is resolved label Apr 11, 2020
@pradyunsg
Copy link
Member Author

Based on #7951 (comment), we need this for 20.1. :)

@pradyunsg pradyunsg mentioned this issue Apr 11, 2020
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation C: automation Automated checks, CI etc !release blocker Hold a release until this is resolved type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
20.1
Development

Successfully merging a pull request may close this issue.

Significantly improve release version validation pradyunsg/pip
2 participants
@brainwane @pradyunsg