Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize "URL" in user guide #7662

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Capitalize "URL" in user guide #7662

merged 1 commit into from
Jan 31, 2020

Conversation

aguiarcandre
Copy link
Contributor

Capitalize "URL" in user guide #7661

@chrahunt chrahunt added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 28, 2020
@chrahunt
Copy link
Member

Test failures seem network-related, so I restarted the failing jobs.

@pfmoore
Copy link
Member

pfmoore commented Jan 28, 2020

The remaining test failures seem unrelated to the change here. From the build logs, it looks like pip's test suite is picking up the newly-released wheel-0.34.1. I wonder if there are problems related to that release which are hitting us?

Problems appear to only be happening with Python 2.7, which I don't have installed locally. I'll try to set up a test environment to check, but if anyone else can see the problem, please shout 🙂

@pradyunsg
Copy link
Member

Mentioning @agronholm to flag this to their attention -- looks like Windows + Python 2.7 + pip install w/ build options + setuptools via PEP 517 isn't working like it used to. :)


As an aside, this is why I strongly prefer having a , result in the assert statements on our tests -- that results in potentially-useful output to help debug situations like these without needing to run them locally.

@agronholm
Copy link
Contributor

I don't know what that test failure is about. But if wheel is somehow causing it, feel free to report a bug.

As an aside, why do you use so many different CI systems? One ought to be enough...? And why run code quality tests on multiple platforms?

@pfmoore
Copy link
Member

pfmoore commented Jan 28, 2020

I don't know what that test failure is about. But if wheel is somehow causing it, feel free to report a bug.

If I can pin down that it actually is wheel, I will. I'm not sure if it is, yet, just something I want to explore, My initial thought was whether the 0.34.0 problems might have been the issue, but then I noticed we were picking up 0.34.1.

As an aside, why do you use so many different CI systems?

A combination of needing Linux, Windows and Mac testing, plus the test suite being so slow that we need to spread the load, plus history and too much complexity that we haven't had time to tidy up.

No, there's no really clever reason that other people could learn from (except maybe "don't do this" 🙂)

@pypa/pip-committers Why do we have code quality checks and docs running so many times???

@agronholm
Copy link
Contributor

A combination of needing Linux, Windows and Mac testing, plus the test suite being so slow that we need to spread the load, plus history and too much complexity that we haven't had time to tidy up.

Yeah, just saying that wheel has all this too but using only Github Actions. Maybe you'd like to take a look? It should be noted that I nixed some combinations in order to make it possible for all the jobs to run in parallel.

@pradyunsg
Copy link
Member

@pypa/pip-committers Why do we have code quality checks and docs running so many times???

This goes to #7279. :)

@chrahunt
Copy link
Member

Why do we have code quality checks and docs running so many times???

#7520 added this, so we always know contributors on any major platform can use the tools.

@agronholm
Copy link
Contributor

#7520 added this, so we always know contributors on any major platform can use the tools.

To me that seems a bit excessive. But, not my project.

@pfmoore
Copy link
Member

pfmoore commented Jan 28, 2020

Anyhow, back to the CI errors - I have not done any tests yet, so this is pure speculation based on the timing, but I wonder if pypa/wheel#331 is the problem here? We seem to be getting this failure in multiple PRs - also noted in #7655 (comment)

@agronholm
Copy link
Contributor

I have not started digging very deep on that yet, and I don't have much time on my hands either (I have a presentation to finish before tomorrow evening). If you find out why v0.33.6 installs but v0.34.1 doesn't, I'd be happy to hear the result.

@chrahunt
Copy link
Member

Rebased on master to fix CI.

@pradyunsg pradyunsg merged commit cc7e34b into pypa:master Jan 31, 2020
@pradyunsg
Copy link
Member

Thanks @aguiarcandre for the PR and @chrahunt, @pfmoore and @agronholm for all the work to resolve the CI issues. :)

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants