Run linters/docs on Windows and macOS #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
skip news
chrahunt
force-pushed
the
maint/cross-platform-lints
branch
from
b8daede to
f6fe88a
Compare
This ensures that contributors on any of the major platforms can run our linting and doc building checks without any changes.
chrahunt
force-pushed
the
maint/cross-platform-lints
branch
from
f6fe88a to
4d1fd08
Compare
Sphinx expects the "document name" field to be normalized with respect to slashes (all /), so we now do this in a portable way for Windows.
Previously we were making unguarded calls to non-Windows-only APIs. Mypy only automatically excludes these from platform-specific checks when inside conditions.
chrahunt
force-pushed
the
maint/cross-platform-lints
branch
from
f6a33b3 to
8dc6919
Compare
Closed
|
Re mypy: how about an |
|
In which case specifically? |
uranusjr
reviewed
Dec 29, 2019
chrahunt
force-pushed
the
maint/cross-platform-lints
branch
2 times, most recently
from
3517432 to
8dc6919
Compare
|
Removing the request for my review, since I'm not sure if I'm the right person for reviewing this. That said, this does look OK to me.
I think that was a prematurely posted comment, sorry about that. I'm not sure what I was referring to there, since none of the call sites seem to be "not-windows" code paths. |
xavfernandez
approved these changes
Jan 1, 2020
|
Thank you for the reviews. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that contributors on any of the major platforms can run our
linting and doc building checks without any changes.