Do not depend on cached download for copying downloaded file #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_check_download_dir will only return a falsy value if either: * the provided path does not exist * the hash does not match - in which case the file is unlinked so the file cannot exist at either of these points.
chrahunt
added
type: refactor
chrahunt
changed the title
|
Do we not need to perform the cheks if the file exists? |
These statements are equivalent, so we exchange them. This will make it easier to factor the download_dir concerns out of these functions.
chrahunt
force-pushed
the
refactor/operations-prepare
branch
from
6e12a9d to
7dea92e
Compare
|
Those changes weren't really critical, so I've dropped the commits. |
|
Maybe we can add a comment pointing here so future maintainers wanting to delete the block don’t need to go through the same discussion again. Or if someone wants to reuse that s/o/a prompt they can maybe move it to somewhere else instead. Otherwise 👍 |
uranusjr
approved these changes
Dec 13, 2019
xavfernandez
approved these changes
Dec 13, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we depended on the result of the check for a cached download in order to decide whether we would copy the downloaded file. Now we do not. This will allow us to eventually extract the copying of the downloaded file out of
unpack_file_urlandunpack_http_url.