Do not depend on cached download for copying downloaded file (#7474)

pypa · Dec 13, 2019 · b9bdad2 · b9bdad2
2 parents b44c217 + 7dea92e
commit b9bdad2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/pip/_internal/operations/prepare.py b/src/pip/_internal/operations/prepare.py
@@ -166,7 +166,9 @@ def unpack_http_url(
         unpack_file(from_path, location, content_type)
 
         # a download dir is specified; let's copy the archive there
-        if download_dir and not already_downloaded_path:
+        if download_dir and not os.path.exists(
+            os.path.join(download_dir, link.filename)
+        ):
             _copy_file(from_path, download_dir, link)
 
 
@@ -260,7 +262,9 @@ def unpack_file_url(
     unpack_file(from_path, location, content_type)
 
     # a download dir is specified and not already downloaded
-    if download_dir and not already_downloaded_path:
+    if download_dir and not os.path.exists(
+        os.path.join(download_dir, link.filename)
+    ):
         _copy_file(from_path, download_dir, link)