Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused WheelBuilder.no_clean #7295

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Remove unused WheelBuilder.no_clean #7295

merged 1 commit into from
Nov 6, 2019

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 4, 2019

WheelBuilder.no_clean is not used anywhere AFAICT, removing it.

@sbidoul sbidoul force-pushed the remove-wb-no_clean-sbi branch from 3af6def to 865f9b3 Compare November 4, 2019 19:33
@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code labels Nov 4, 2019
chrahunt
chrahunt approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #5661. I don't see any problem with removing this unused and untested parameter and then using that issue to track the actual implementation.

@chrahunt chrahunt force-pushed the remove-wb-no_clean-sbi branch from 865f9b3 to 92a9183 Compare November 5, 2019 03:58
@chrahunt
Copy link
Member

chrahunt commented Nov 5, 2019

Rebased on master after merging #7288.

@chrahunt chrahunt merged commit 7e84f24 into pypa:master Nov 6, 2019
@sbidoul sbidoul deleted the remove-wb-no_clean-sbi branch November 16, 2019 16:36
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbidoul @chrahunt