-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new wheel_builder module and move WheelBuilder+friends #7288
Create a new wheel_builder module and move WheelBuilder+friends #7288
Conversation
This is a good thing to move out IMO. I would also move the tests. |
This is already a pretty huge PR as is, so I'm weary of adding more things to it. I'd prefer to move tests in a follow up. |
Actually, you're right -- there's only 1 test for WheelBuilder (ahahahahahaha) and that's failing already. I'll move that into it's own file, as a reminder that we need to expand these tests. |
@pradyunsg it would be cool if #7285 could go be merged before, as it's my second attempt and the previous one was also killed by a refactoring underneath it. 🙏 |
@sbidoul Yep yep -- that's on my radar. Don't worry, I don't plan on merging this change before that PR. :) Edit: To be clear, even if I do, I don't expect there to be any major issues or merge conflicts with this PR (a |
9f10b82
to
9eb4352
Compare
Why: Allows for better code reuse, without introducing dependency between wheel->wheel_builder.
9eb4352
to
b1f2f74
Compare
Updated after #7285 merged. :) |
Moves WheelBuilder and friends into a dedicated module.
These are already basically independent from the rest of
pip._internal.wheel
so doing so makes a lot of sense IMO. Reduces ~500 lines from wheel.py.Refactor done w/ PyCharm's refactoring tools + cleanup.