-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PipSession to network.session #7089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
Refactoring code
skip news
Does not need a NEWS file entry (eg: trivial changes)
labels
Sep 26, 2019
pradyunsg
reviewed
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in principle -- one minor comment.
[naming] Would network.session
be a better name for this module?
Sure, I think I prefer it to |
This new module is a catch-all for PipSession helpers.
chrahunt
changed the title
Move PipSession to network.requests
Move PipSession to network.session
Sep 27, 2019
chrahunt
force-pushed
the
refactor/move-pip-session
branch
from
September 27, 2019 05:08
e6e7ea3
to
c40331e
Compare
xavfernandez
approved these changes
Sep 27, 2019
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Oct 1, 2019
Function url_to_path() moved to `pip._internal.utils.urls`. See pypa/pip#7089
3 tasks
lock
bot
added
the
auto-locked
Outdated issues that have been locked by automation
label
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
auto-locked
Outdated issues that have been locked by automation
skip news
Does not need a NEWS file entry (eg: trivial changes)
type: refactor
Refactoring code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work done in #7045 and #7062 to reduce the size of, and variety of things in,
pip._internal.download
.