Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PipSession to network.session #7089

Merged
merged 4 commits into from
Sep 28, 2019

Conversation

chrahunt
Copy link
Member

Continues the work done in #7045 and #7062 to reduce the size of, and variety of things in, pip._internal.download.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Sep 26, 2019
@chrahunt chrahunt marked this pull request as ready for review September 27, 2019 00:45
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle -- one minor comment.

[naming] Would network.session be a better name for this module?

@chrahunt
Copy link
Member Author

Sure, I think I prefer it to network.requests.

@chrahunt chrahunt changed the title Move PipSession to network.requests Move PipSession to network.session Sep 27, 2019
@pradyunsg pradyunsg merged commit ad33ece into pypa:master Sep 28, 2019
@chrahunt chrahunt deleted the refactor/move-pip-session branch September 28, 2019 07:07
atugushev added a commit to atugushev/pip-tools that referenced this pull request Oct 1, 2019
Function url_to_path() moved to `pip._internal.utils.urls`.
See pypa/pip#7089
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants