Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url_to_path() import #915

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 1, 2019

Function url_to_path() has been moved to pip._internal.utils.urls.
See pypa/pip#7089

Changelog-friendly one-liner: Add compatibility with pip==19.3.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Function url_to_path() moved to `pip._internal.utils.urls`.
See pypa/pip#7089
@atugushev atugushev added this to the 4.2.0 milestone Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #915 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   99.06%   99.08%   +0.01%     
==========================================
  Files          35       35              
  Lines        2247     2285      +38     
  Branches      288      301      +13     
==========================================
+ Hits         2226     2264      +38     
  Misses         13       13              
  Partials        8        8
Impacted Files Coverage Δ
tests/test_cli_compile.py 100% <0%> (ø) ⬆️
piptools/writer.py 99.31% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a4e99...aa2015f. Read the comment docs.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atugushev atugushev merged commit e1d2212 into jazzband:master Oct 4, 2019
@atugushev atugushev deleted the fix-url_to_path-import branch October 4, 2019 01:03
@atugushev
Copy link
Member Author

Thanks as always @codingjoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants