Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully support --trusted-host inside requirements files #6603

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Fully support --trusted-host inside requirements files #6603

merged 2 commits into from
Jun 14, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #3799. (This is a follow-on to PR #6597.)

@cjerdonek cjerdonek added C: download About fetching data from PyPI and other sources C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality labels Jun 13, 2019
@cjerdonek cjerdonek mentioned this pull request Jun 13, 2019
Closed
@cjerdonek cjerdonek force-pushed the issue-3799-trusted-host-requirements-txt branch 3 times, most recently from 7fbc3da to 92ad78c Compare June 13, 2019 08:07
@cjerdonek cjerdonek force-pushed the issue-3799-trusted-host-requirements-txt branch from 92ad78c to d727583 Compare June 13, 2019 08:21
pradyunsg
pradyunsg approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed - LGTM.

I've not tested this locally but the tests seem good to me.

@cjerdonek
Copy link
Member Author

FYI, I added another commit to the PR to log when a --trusted-host is being added from a file. The message looks like this (at INFO level):

INFO: adding trusted host: 'example.com' (from line 5 of file.txt)

@pradyunsg
Copy link
Member

pradyunsg commented Jun 14, 2019 •
edited
Loading

That looks pretty great @cjerdonek! Nice thought (and pretty clean implementation).

@cjerdonek
Copy link
Member Author

Thanks, @pradyunsg!

@cjerdonek cjerdonek merged commit 28592c3 into pypa:master Jun 14, 2019
@cjerdonek cjerdonek deleted the issue-3799-trusted-host-requirements-txt branch June 14, 2019 21:48
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: download About fetching data from PyPI and other sources C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--trusted-host in requirements.txt is ignored
2 participants
@cjerdonek @pradyunsg