Store PackageFinder.trusted_hosts instead of secure_origins #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
type: refactor
cjerdonek
force-pushed
the
simplify-finder-secure-origins
branch
2 times, most recently
from
bbb61dc to
cd616a4
Compare
cjerdonek
force-pushed
the
simplify-finder-secure-origins
branch
from
cd616a4 to
4c1ccae
Compare
|
Thanks! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
PackageFinderclass by storing the originaltrusted_hostsinstead ofsecure_origins. As you can see from the PR, a couple interactions with thePackageFinderclass become simplified when this happens. It also simplifies thecreate()method and makes the computation of thesecure_originsseparately testable (which this PR does).