Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Resolver to a legacy_resolve module #6535

Merged
merged 2 commits into from
May 25, 2019
Merged

Move Resolver to a legacy_resolve module #6535

merged 2 commits into from
May 25, 2019

Conversation

pradyunsg
Copy link
Member

This better represents the state of things going forward and I'll be filing follow ups to start working on the new resolver in-place soon.

@pradyunsg pradyunsg added type: refactor Refactoring code C: dependency resolution About choosing which dependencies to install labels May 25, 2019
@cjerdonek
Copy link
Member

cjerdonek commented May 25, 2019 •
edited
Loading

@pradyunsg I had a PR already up that touches resolve.py. Would you be able to look at that first? #6528

@pradyunsg
Copy link
Member Author

Definitely! :D

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 25, 2019
cjerdonek
cjerdonek approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you should also rename tests/unit/test_resolve.py to tests/unit/test_legacy_resolve.py, since that test module is specific to that file.

@pradyunsg
Copy link
Member Author

Makes sense to me!

@pradyunsg
Copy link
Member Author

Thanks for the super quick feedback on this @cjerdonek! :D

@pradyunsg pradyunsg merged commit c197b11 into pypa:master May 25, 2019
@pradyunsg pradyunsg deleted the move-resolver branch May 25, 2019 17:36
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjerdonek cjerdonek cjerdonek approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @cjerdonek