-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make _check_dist_requires_python() parallel _check_link_requires_python(), and add more complete tests #6528
Conversation
583d181
to
22b2d15
Compare
69fb9bb
to
12db11c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check_dist_requires_python
may be used in other locations too (like for checking the highest version of pip that supports a given version of Python once support is dropped; that's a feature request marked "good first issue"). I don't think it should be moved into resolve.py
or suffixed with an _
.
I do like the other changes in this PR.
Can that wait until the future change actually happens? Right now |
As a compromise, can I move just |
Sounds fair to me. |
12db11c
to
f82ea77
Compare
Okay, thanks, @pradyunsg. I've updated the PR. |
This PR (1) moves
check_dist_requires_python()
toresolve.py
where it used, (2) makes its implementation closely parallelindex.py
's_check_link_requires_python()
, (3) adds anignore_requires_python
argument (like_check_link_requires_python()
), and (4) tests it quite fully (including log messages, exception messages, and all branch logic). It also sets us up for passingpy_version_info
to theResolver
class, which will help with other issues.This is a refactor in preparation for addressing issue #5369 ("
pip download --python-version
fails when downloaded package doesn't support the Python version running pip") and related issues.