Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support special characters like # and @ in VCS revision strings #6496

Closed
wants to merge 3 commits into from
Closed

[WIP] Support special characters like # and @ in VCS revision strings #6496

wants to merge 3 commits into from

Conversation

cjerdonek
Copy link
Member

Fixes #5742.

@cjerdonek cjerdonek added C: vcs pip's interaction with version control systems like git, svn and bzr type: enhancement Improvements to functionality labels May 12, 2019
@cjerdonek cjerdonek mentioned this pull request May 12, 2019
Closed
@cjerdonek cjerdonek changed the title Support special characters like # and @ in VCS revision strings [Support special characters like # and @ in VCS revision strings May 12, 2019
@cjerdonek cjerdonek changed the title [Support special characters like # and @ in VCS revision strings [WIP] Support special characters like # and @ in VCS revision strings May 12, 2019
@cjerdonek cjerdonek force-pushed the issue-5742-vcs-revision-special-chars branch from 20dbe5b to 2133c1d Compare May 12, 2019 19:03
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 19, 2019
@cjerdonek cjerdonek mentioned this pull request Sep 8, 2019
Closed
@chrahunt
Copy link
Member

This looks like it is superseded by #6958. Any objections to closing it and moving "Fixes #5742" to the other issue?

@pradyunsg
Copy link
Member

Nope.

@pradyunsg pradyunsg closed this Jan 7, 2020
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr needs rebase or merge PR has conflicts with current master type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support special characters like # in Git branch names
4 participants
@cjerdonek @BrownTruck @chrahunt @pradyunsg