Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support special characters like # in Git branch names #5742

Closed
cjerdonek opened this issue Aug 27, 2018 · 3 comments
Closed

Support special characters like # in Git branch names #5742

cjerdonek opened this issue Aug 27, 2018 · 3 comments
Labels
C: vcs pip's interaction with version control systems like git, svn and bzr type: enhancement Improvements to functionality

Comments

@cjerdonek
Copy link
Member

See PR #4813 for where this was originally suggested.

The solution could involve, for example, escaping / quoting the name.
@cjerdonek cjerdonek added C: vcs pip's interaction with version control systems like git, svn and bzr state: needs discussion This needs some more discussion type: feature request Request for a new feature type: enhancement Improvements to functionality and removed type: feature request Request for a new feature labels Aug 27, 2018
@cjerdonek cjerdonek mentioned this issue Aug 27, 2018
Closed
@cjerdonek cjerdonek mentioned this issue May 12, 2019
Closed
@cjerdonek cjerdonek removed the state: needs discussion This needs some more discussion label May 12, 2019
@cjerdonek
Copy link
Member Author

I posted PR #6496 for this.

@chrahunt
Copy link
Member

#6958 is also related to this.

@chrahunt chrahunt added the state: awaiting PR Feature discussed, PR is needed label Dec 24, 2019
@deveshks
Copy link
Contributor

I think we can close this issue, since it has been fixed by #7596 after picking up the work from #6958

@pradyunsg pradyunsg removed the state: awaiting PR Feature discussed, PR is needed label Apr 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C: vcs pip's interaction with version control systems like git, svn and bzr type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Support special characters like # and @ in VCS revision strings cjerdonek/pip
4 participants
@cjerdonek @chrahunt @pradyunsg @deveshks