Don't print stacktrace due to invalid req #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psinghsodhi
force-pushed
the
stopPrintSt
branch
from
8d544ea to
e34b19b
Compare
|
Thanks for the PR! :) I don't think this is in itself enough to fix #5147, but it's definitely an improvement. |
pradyunsg
approved these changes
Oct 27, 2018
| @@ -258,7 +257,7 @@ def install_req_from_line( | |||
| elif '=' in req and not any(op in req for op in operators): | |||
| add_msg = "= is not a valid operator. Did you mean == ?" | |||
| else: | |||
| add_msg = traceback.format_exc() | |||
| add_msg = "" | |||
There was a problem hiding this comment.
Ideally, I'd say we'd llike an additional logger.debug() to have the traceback in verbose mode
|
I'll go ahead and merge this; will follow up with more improvements here. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixesToward #5147Closes #5170