Merge pull request #5923 from psinghsodhi/stopPrintSt

Don't print stacktrace due to invalid req

news/5147.bugfix

@@ -0,0 +1 @@
+Invalid requirement no longer causes stack trace to be printed.

src/pip/_internal/req/constructors.py

@@ -11,7 +11,6 @@
 import logging
 import os
 import re
-import traceback
 
 from pip._vendor.packaging.markers import Marker
 from pip._vendor.packaging.requirements import InvalidRequirement, Requirement
@@ -258,7 +257,7 @@ def install_req_from_line(
             elif '=' in req and not any(op in req for op in operators):
                 add_msg = "= is not a valid operator. Did you mean == ?"
             else:
-                add_msg = traceback.format_exc()
+                add_msg = ""
             raise InstallationError(
                 "Invalid requirement: '%s'\n%s" % (req, add_msg)
             )

tests/unit/test_req.py

@@ -542,12 +542,12 @@ def test_single_equal_sign(self):
         assert "Invalid requirement" in err_msg
         assert "= is not a valid operator. Did you mean == ?" in err_msg
 
-    def test_traceback(self):
+    def test_unidentifiable_name(self):
+        test_name = '-'
         with pytest.raises(InstallationError) as e:
-            install_req_from_line('toto 42')
+            install_req_from_line(test_name)
         err_msg = e.value.args[0]
-        assert "Invalid requirement" in err_msg
-        assert "\nTraceback " in err_msg
+        assert ("Invalid requirement: '%s'\n" % test_name) == err_msg
 
     def test_requirement_file(self):
         req_file_path = os.path.join(self.tempdir, 'test.txt')