Use a single setuptools shim

[xavfernandez]

for all setup.py invocations

[xavfernandez]

I think this "lame hack" present since c2000d7 (7 years now) could now be removed ?

[xavfernandez]

cc @dstufft (I'm talking of the egg_info.egg_info.run = replacement_run bit)

[rbtcollins]

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

---

pip/req/req_install.py, line 460 [r1] (raw file):
Have you checked to see if PasteScript has been fixed?

---

pip/req/req_install.py, line 473 [r2] (raw file):
The ; here is gross - why is it needed?

---

pip/utils/init.py, line 825 [r2] (raw file):
Could we keep this in req_install? Its closer to the users there. Or maybe in a dedicated setuptools_build.py file?

---

Comments from the review on Reviewable.io

[xavfernandez]

pip/req/req_install.py, line 460 [r1] (raw file):
Well I'm not sure what this hack was supposed to fix :-/

But pip 7.1.2 is currently enable to install PasteScript 0.3/0.3.1 and seems to work with most other versions including the last ones (I didn't try all of them).

Removing the hack leads to the same result: crashes with 0.3/0.3.1 and seems to work with other versions including the last ones.

---

Comments from the review on Reviewable.io

[xavfernandez]

pip/req/req_install.py, line 460 [r1] (raw file):
err I meant "pip 7.1.2 is currently unable"

---

Comments from the review on Reviewable.io

[xavfernandez]

Updated, cc @rbtcollins @dstufft

[rbtcollins]

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.

---

pip/req/req_install.py, line 460 [r1] (raw file):
Well if current pip can't do it, being no worse is ok; still, lets do that as a separate change.

---

Comments from the review on Reviewable.io