Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-ASCII setup.py when running on Python 3 #2916

Closed
wants to merge 2 commits into from
Closed

Accept non-ASCII setup.py when running on Python 3 #2916

wants to merge 2 commits into from

Conversation

Suzumizaki
Copy link

@Suzumizaki Suzumizaki commented Jun 19, 2015

When running on Python 3 and setup.py includes non-ASCII characters,
'pip install xxx' will fail at building the wheel infomation.

This patch will fix the problem.
Thanks!

Review on Reviewable

@Suzumizaki
Copy link
Author

Sorry, I found your(rbtcollins's) message after my 2nd push. I will research linecache later. (I can't imagine what's wrong currently).

Edited:
I can't make sure why the original code took this approach, and I don't know how the code should be.
To be exact, that is another issue. Please tell me how or fix the code directly.

@xavfernandez
Copy link
Member

It should now be fixed via #3265

@dstufft dstufft closed this May 18, 2016
@dstufft
Copy link
Member

dstufft commented May 18, 2016

Accidentally closed this, reopening. Sorry!

@dstufft dstufft reopened this May 18, 2016
@BrownTruck
Copy link
Contributor

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

When running on Python 3 and setup.py includes non-ASCII characters,
'pip install xxx' will fail at building the wheel infomation.

This patch will fix the problem.
Thanks!

---

*This was migrated from pypa/pip#2916 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@BrownTruck
Copy link
Contributor

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

@BrownTruck BrownTruck added auto-bitrotten PRs that died because they weren't updated and removed asked to reparent labels May 26, 2016
@BrownTruck BrownTruck closed this May 26, 2016
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-bitrotten PRs that died because they weren't updated auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants