Normalise paths when comparing egg-link from network drive

[freakboy3742]

This is a resurrection of #9453 which was closed due to bitrot. It may also be a fix for #8598.

On Windows, when a package is installed as editable, and the source is on a network drive, the mypkg.egg_link file references a Windows drive letter (e.g., Z:\somewhere\mypkg); however, easy-install.pth file stores the location as a UNC name (e.g., \\network-drive\somewhere\mypkg).

Although these are the same paths when normalised, the comparison is performed on un-normalized paths, which results in an error when you attempt to uninstall the package.

[pypa-bot]

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

[freakboy3742]

I'm aware that this PR doesn't have tests; however, I'm having difficulty finding an entry point for those tests. I can't find any obvious place where the existing functionality is currently being tested; nor can I find any reference to any methods that would cause this code to be exercised. Any pointers on where I should be looking to develop a test for this would be appreciated.

[uranusjr]

Huh, I though samefile covered that. That change was actually pretty recent to support junction links.

This would be very difficult to test so let’s not bother.

[pradyunsg]

I agree, it’s likely fine to skip testing this entirely. We should normalise both values though and pacify the linters. :)

[freakboy3742]

@pradyunsg PR now normalises both values, and the linter has been bought a cookie and an ice cream :-)

[pradyunsg]

Thanks @freakboy3742! ^.^