-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manylinux_2_24 images #822
Conversation
latest autofconf was released in 2012, use the system provided one which is the latest on CentOS 7
Add manylinux2014_ppc64le image
Update pyelftools from 0.25 to 0.26
- Update CPython 3.6 from 3.6.9 to 3.6.10 - Update CPython 3.7 from 3.7.5 to 3.7.6 - Update CPython 3.8 from 3.8.0 to 3.8.1
Bumps [setuptools](https://github.com/pypa/setuptools) from 42.0.2 to 45.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v42.0.2...v45.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [pip](https://github.com/pypa/pip) from 19.3.1 to 20.0.2. - [Release notes](https://github.com/pypa/pip/releases) - [Changelog](https://github.com/pypa/pip/blob/master/NEWS.rst) - [Commits](pypa/pip@19.3.1...20.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
) Bumps [setuptools](https://github.com/pypa/setuptools) from 45.0.0 to 45.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v45.0.0...v45.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
) Bumps [setuptools](https://github.com/pypa/setuptools) from 45.1.0 to 45.2.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v45.1.0...v45.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [setuptools](https://github.com/pypa/setuptools) from 45.2.0 to 46.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v45.2.0...v46.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
) Bumps [setuptools](https://github.com/pypa/setuptools) from 46.0.0 to 46.1.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v46.0.0...v46.1.1) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
) Bumps [setuptools](https://github.com/pypa/setuptools) from 46.1.1 to 46.1.3. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v46.1.1...v46.1.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [wheel](https://github.com/pypa/wheel) from 0.31.1 to 0.34.2. - [Release notes](https://github.com/pypa/wheel/releases) - [Changelog](https://github.com/pypa/wheel/blob/master/docs/news.rst) - [Commits](pypa/wheel@0.31.1...0.34.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [auditwheel](https://github.com/pypa/auditwheel) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/pypa/auditwheel/releases) - [Changelog](https://github.com/pypa/auditwheel/blob/master/CHANGELOG.md) - [Commits](pypa/auditwheel@3.0.0...3.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
* Bump auditwheel from 3.2.0 to 3.3.0 in /docker/build_scripts Bumps [auditwheel](https://github.com/pypa/auditwheel) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/pypa/auditwheel/releases) - [Changelog](https://github.com/pypa/auditwheel/blob/master/CHANGELOG.md) - [Commits](pypa/auditwheel@3.2.0...3.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * Bump wheel from 0.34.2 to 0.36.1 in /docker/build_scripts Bumps [wheel](https://github.com/pypa/wheel) from 0.34.2 to 0.36.1. - [Release notes](https://github.com/pypa/wheel/releases) - [Changelog](https://github.com/pypa/wheel/blob/master/docs/news.rst) - [Commits](pypa/wheel@0.34.2...0.36.1) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Do not update epel-release package for now c.f. nealef/clefos#5
…pypa#871) Bumps [setuptools](https://github.com/pypa/setuptools) from 50.3.2 to 51.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](pypa/setuptools@v50.3.2...v51.0.0)
58d9511
to
670fd25
Compare
How would you suggest we proceed with getting this reviewed and merged? It is a massive PR. Is there a way to break it into pieces either as separate PRs or at least some kind of "guide for reviewers"? |
Or maybe set up a synchronous call with some PyPA maintainers to walk them through it? |
As mentioned in "PS":
I created #873 to at least allow a review commit by commit. Nevertheless, commit 76dee71 will be a big one (breaks the "almost monolithic" pinging @pypa/manylinux if they want to chime in on the way to proceed forward. |
I will open one PR per tool migration for 76dee71 meaning I'll also do a few PR before that that build one on top of the others. So be it for the docker cache on my machine. I'll let travis-ci do the check and only build locally on errors if any in the meantime. I can't get this PR back in draft, do not merge this. |
I can apparently mark it as draft. Would you like me to? |
I propose the following strategy in order to get "this" merged: I will create an issue to track the progress (but I'll keep this PR opened for now as a reference to where I'd like things to converge). Edit: issue #877 created to discuss this further |
You might find Projects helpful to track this work. |
Superseded by #999 |
This adds manylinux_2_24 images and rework the master branch to build
manylinux2010
,manylinux2014
andmanylinux_2_24
from a single branch.The build scripts were reworked for maintainers to be able to rebuild images taking advantage of docker cache.
This obviously has pros and cons compared to the previous
one step
build scripts. Here are my thoughts:pros:
if
yum
orapt
are making our life difficult when it comes to removing packages to restore a previous state, i.e. something like alpine'sapk add --virtual build-deps ...
/apk del build-deps
)cons:
Please do provide feedback about rewriting as proposed. If you have other proposals on how you think it should be done, please do tell.
Some of the scripts might not be considered
docker cache
friendly. This is especially the case forinstall-entrypoint.sh
,install-runtime-packages.sh
andinstall-build-packages.sh
. My motivation for doing things like this is that it helps getting consistency between images and those files are likely to change only when adding a new set of images which will not happen that often I guess. Forinstall-build-packages.sh
, it might also change when adding a new tool. This will have an impact on all images so should not be an issue.This removes CPython 2.7 on manylinux2010 image.
README is not updated yet, waiting for feedback on other parts before doing this.
PS: This PR is also merging
manylinux2014
inmaster
not to lose history. This accounts for the high number of commits. I can open another PR targetingmanylinux2014
branch first if this helps review.