-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign scripts to build all images from a single branch #877
Comments
With some of these changes, the docker image now has many more layers. Docker has an upper limit on the total number of layers that an image can have (it is around 128, but I am not certain), and having more layers here mean that downstream docker images that build on it have fewer layers that they can add. I recognize that having more layers makes these scripts more docker cache friendly for manylinux, but more docker cache hostile for downstream docker images. Please don't add too many more layers. |
@manthey, |
Thanks, @mayeut. |
As proposed in #542 (comment), this issue is created to propose and track progress of a rewrite of
manylinux
build scripts to build all images from a single branch.With new
manylinux
policies allowed by PEP600, we'll have more and more images. Creating a branch per policy will cause issues for maintainability and consistency between images (or even README).manylinux1
is out-of-scope for the rewrite for now (c.f. #542 (comment) for rational)Here are the steps I propose, feel free to challenge those.
PRs referenced here will build one on top of the other requiring them to be reviewed sequentially.
Rework the
manylinux2014
branch to allow for multiple policiesRational for choosing this as the base branch of the rework:
manylinux2014
branch builds on all platforms which allows to see issues that would otherwise not be seen until a later point.Merge
manylinux2014
inmaster
At this point, we'll be ready to add new images for newer PEP600 policies
glibc
onmanylinux2010
([manylinux2010] glibc update & glibc cache/image size reduction #874)quay.io/pypa/manylinux2010_centos-6-no-vsyscall
(Publish quay.io/pypa/manylinux2010_centos-6-no-vsyscall #878)manylinux2010
build support inmanylinux2014
branch ([manylinux2014] Allow manylinux2010 build from manylinux2014 branch #979)master
(Merge manylinux2014 branch in master branch #993)Add
manylinux_2_24
images (Add manylinux_2_24 images #999)Rational for adding this specific policy: It solves issues for
numpy ppc64le
c.f. Tracking issue for PEP 600 Perennial manylinux rollout #542 (comment),numpy
being the most downloadedmanylinux
package it seems a good starting point as it's also probably used as a dependency in a high number ofmanylinux
packages which will thus benefit from this.@pypa/manylinux, please do provide feedback as your time allows, thanks.
The text was updated successfully, but these errors were encountered: