Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Python 3.8, Install python with official installer if an official install is not found on windows #186

Closed
wants to merge 3 commits into from

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Nov 1, 2019

Vendor-In pep514tools

Draft to following discussion in #172

@mayeut mayeut mentioned this pull request Nov 1, 2019
@mayeut mayeut marked this pull request as ready for review November 2, 2019 11:20
@mayeut mayeut changed the title Install python with official installer if an official install is not found Adding Python 3.8, Install python with official installer if an official install is not found on windows Nov 2, 2019
Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm especially impressed by/happy with the minimal amount of changes that were necessary to implement this all!

.travis.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
cibuildwheel/_vendored/pep514tools/LICENSE Show resolved Hide resolved
cibuildwheel/windows.py Show resolved Hide resolved
cibuildwheel/windows.py Show resolved Hide resolved
cibuildwheel/windows.py Show resolved Hide resolved
cibuildwheel/windows.py Outdated Show resolved Hide resolved
Also replace double-space by a backslash to show intent of a line-break.
@joerick
Copy link
Contributor

joerick commented Nov 4, 2019

Closed in favour of #180

@joerick joerick closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants