Adding Python 3.8, Always use nuget to install python on Windows #180

mayeut · 2019-10-26T00:33:46Z

Just a draft to check if it works on all windows providers.
c.f. #172 for full discussion

YannickJadoul · 2019-10-30T22:56:13Z

EDIT: Argh, sorry, wrong PR. Moved to #184 (comment)

cibuildwheel/windows.py

YannickJadoul

Sweet! I love the amount of lines that can be removed! :)

README.md

cibuildwheel/windows.py

YannickJadoul · 2019-11-02T23:33:34Z

cibuildwheel/windows.py

-        # no easy and stable way fo installing python 3.4 
-        python_configurations = [c for c in python_configurations if c.version != '2.7.x' and c.version != '3.4.x']
+        # no easy and stable way fo installing python 3.4
+        python_configurations = [c for c in python_configurations if c.version != '2.7.x']


Is this still up to date? At least the comment about 3.4 isn't.
Why can't we get nuget 2.7 on Travis?

argh, I forgot I had to drop python 3.4 on this PR (no nuget python 3.4).
The issue on travis with 2.7 is not install python but the tools needed to build native code for python 2.7

Ah, so it might be good to leave merging this PR until after we drop 3.4?

On the 2.7: is it really necessary to keep worrying about these VS tools for 2.7? I'm building C++17 wheels for Python 2.7 (without the ancient compiler VS offers for 2.7). I've tested this and it does work. The only catch is that "Microsoft Visual C++ Redistributable for Visual Studio 2017" needs to be installed, then, so I added a section about that to my docs.

My point being: maybe we could still offer 2.7, but make people aware that the tools won't be installed?

IMHO, this goes against the generic wheel principles (I think) which is, pip install should always work, no matter what, no need for further installs. My point is that if we want to offer python 2.7 support on travis, then it shall be an opt-in, not the default. This would require a specific PR.
Anyway, python 2.7 is EOL in less than 2 months. Shall we really do specific things for it ?

Hmmm, that's also true, yes. And there's still AppVeyor anyway.

Ah, so it might be good to leave merging this PR until after we drop 3.4?

yes, if we want to merge it after #186 (official vs nuget). My guess is that in a couple months (after python 2.7/3.4) have been dropped, the only difference between the 2 PRs will be what to install and that, with official installers, we'll still need pep514tools vendored-in. The code in windows.py will be almost the same, whatever the PR.

YannickJadoul · 2019-11-02T23:35:20Z

cibuildwheel/windows.py

+    download('https://dist.nuget.org/win-x86-commandline/latest/nuget.exe', nuget)
+    # get pip fo this installation which not have.
+    get_pip_script = 'C:\\get-pip.py'
+    download('https://bootstrap.pypa.io/get-pip.py', get_pip_script)


Just curious: do nuget versions not have pip installed?

I've not redone the test, it's merely a rewrite of the travis-ci PR which was doing this.

I'm not sure we hit the conditional statement lower in the code.

Hmmm, two lines and a download. Not sure if it's worth testing whether we can remove the lines.

Seems pip is not installed

Hmmm, two lines and a download. Not sure if it's worth testing whether we can remove the lines.

Not sure I fully understand this comment. If it only refers to get-pip then no, we can't remove those (now tested).

Yeah, that's what I meant. That's kind of silly. Why do all these distributions not have pip installed?

cibuildwheel/windows.py

mayeut · 2019-11-03T09:49:11Z

Depends on #168 (sort of), drops python 3.4 on windows.

joerick · 2019-11-04T19:26:07Z

This is looking good to me! Anything else you'd like to do before merging @mayeut ?

Also replace double-space by a backslash to show intent of a line-break.

mayeut · 2019-11-04T21:23:30Z

@joerick, it seemed it was not possible to merge the PR with the merge you did. Instead, I rebased on the new master. Looks good to me, let's wait for CI.

Matt$ diff -ruN -x .git cibuildwheel.bak cibuildwheel
diff -ruN -x .git cibuildwheel.bak/cibuildwheel/windows.py cibuildwheel/cibuildwheel/windows.py
--- cibuildwheel.bak/cibuildwheel/windows.py	2019-11-04 22:00:42.000000000 +0100
+++ cibuildwheel/cibuildwheel/windows.py	2019-11-04 22:07:06.000000000 +0100
@@ -9,9 +9,9 @@
     from pipes import quote as shlex_quote
 
 try:
-    from urllib2 import urlopen
-except ImportError:
     from urllib.request import urlopen
+except ImportError:
+    from urllib2 import urlopen
 
 from .util import prepare_command, get_build_verbosity_extra_flags
 
diff -ruN -x .git cibuildwheel.bak/test/shared/utils.py cibuildwheel/test/shared/utils.py
--- cibuildwheel.bak/test/shared/utils.py	2019-11-04 22:00:42.000000000 +0100
+++ cibuildwheel/test/shared/utils.py	2019-11-04 22:08:34.000000000 +0100
@@ -99,7 +99,7 @@
         raise Exception('unsupported platform')
 
     if IS_WINDOWS_RUNNING_ON_TRAVIS:
-        # Python 2.7 and 3.4 isn't supported on Travis.
+        # Python 2.7 isn't supported on Travis.
         templates = [t for t in templates if '-cp27-' not in t]
 
     return [filename.format(package_name=package_name, package_version=package_version)

cibuildwheel/macos.py

joerick · 2019-11-04T22:13:48Z

Those README updates are okay, I think it will be simpler once @Czaki's PR is merged anyway.

mayeut · 2019-11-04T22:19:43Z

The only CI check remaining is AppVeyor which is rebuilding the 4 commits for the README change so it will take around 1h30 to get the all green CI status. (they are not building the commit they claim to be building anyway... otherwise, it would have already failed for the first 3 unexisting commits...)

PS: @joerick, I can cancel/restart jobs on travis-ci but this doesn't seem to be the case on AppVeyor (I wanted to clean-up the build queue but not possible)

mayeut · 2019-11-04T22:51:05Z

@joerick, LGTM.

According to pypa/cibuildwheel#180

mayeut force-pushed the nuget branch from 4f69c84 to 9af99df Compare October 26, 2019 13:54

mayeut mentioned this pull request Oct 30, 2019

Adding Python 3.8 #172

Closed

mayeut force-pushed the nuget branch from fbe1c45 to 4d2784a Compare November 2, 2019 10:01

mayeut changed the title ~~Always use nuget to install python on Windows~~ Adding Python 3.8, Always use nuget to install python on Windows Nov 2, 2019

mayeut marked this pull request as ready for review November 2, 2019 12:11

mayeut mentioned this pull request Nov 2, 2019

Adding Python 3.8, Install python with nuget if not found on windows #182

Closed

nsoranzo reviewed Nov 2, 2019

View reviewed changes

cibuildwheel/windows.py Outdated Show resolved Hide resolved

YannickJadoul reviewed Nov 2, 2019

View reviewed changes

mayeut force-pushed the nuget branch from 4d2784a to 66007f7 Compare November 3, 2019 09:37

mayeut force-pushed the nuget branch 5 times, most recently from faa3168 to b168fee Compare November 3, 2019 12:56

joerick mentioned this pull request Nov 4, 2019

Adding Python 3.8, Install python with official installer if an official install is not found on windows #186

Closed

joerick mentioned this pull request Nov 4, 2019

Add support for Python 3.8 #170

Closed

mayeut added 2 commits November 4, 2019 22:05

Remove trailing-spaces from README.md

58048b4

Also replace double-space by a backslash to show intent of a line-break.

Always use nuget to install python on Windows

f2ef7a6

mayeut force-pushed the nuget branch from d45f775 to e6909a8 Compare November 4, 2019 21:15

Add python 3.8 support

104dcf1

mayeut force-pushed the nuget branch from e6909a8 to 104dcf1 Compare November 4, 2019 21:23

Czaki reviewed Nov 4, 2019

View reviewed changes

cibuildwheel/macos.py Show resolved Hide resolved

mayeut force-pushed the nuget branch 2 times, most recently from e82c5f7 to a95e596 Compare November 4, 2019 21:47

Fix documentation for macOS python 3.8

05ab66c

mayeut force-pushed the nuget branch from a95e596 to 05ab66c Compare November 4, 2019 21:49

joerick merged commit 89e2ac7 into pypa:master Nov 5, 2019

mayeut deleted the nuget branch November 5, 2019 21:02

YannickJadoul mentioned this pull request Nov 9, 2019

Use specific cibw directory on Windows to prevent collisions with installed software #197

Merged

mayeut mentioned this pull request Nov 10, 2019

Rework platform detection to ignore CI provider. #204

Merged

Czaki mentioned this pull request Mar 22, 2020

Add MacOS 10.14 and manylinux2014 wheel builds vispy/vispy#1843

Merged

djhoese added a commit to djhoese/pykdtree that referenced this pull request Mar 23, 2020

Simplify Azure Windows tasks

9f1ab44

According to pypa/cibuildwheel#180

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Python 3.8, Always use nuget to install python on Windows #180

Adding Python 3.8, Always use nuget to install python on Windows #180

mayeut commented Oct 26, 2019

YannickJadoul commented Oct 30, 2019 •

edited

Loading

YannickJadoul left a comment

YannickJadoul Nov 2, 2019

mayeut Nov 3, 2019 •

edited

Loading

YannickJadoul Nov 3, 2019

mayeut Nov 3, 2019

YannickJadoul Nov 3, 2019

mayeut Nov 3, 2019

YannickJadoul Nov 2, 2019

mayeut Nov 3, 2019

mayeut Nov 3, 2019

YannickJadoul Nov 3, 2019

mayeut Nov 3, 2019

YannickJadoul Nov 3, 2019

mayeut commented Nov 3, 2019

joerick commented Nov 4, 2019

mayeut commented Nov 4, 2019 •

edited

Loading

joerick commented Nov 4, 2019

mayeut commented Nov 4, 2019 •

edited

Loading

mayeut commented Nov 4, 2019

Adding Python 3.8, Always use nuget to install python on Windows #180

Adding Python 3.8, Always use nuget to install python on Windows #180

Conversation

mayeut commented Oct 26, 2019

YannickJadoul commented Oct 30, 2019 • edited Loading

YannickJadoul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayeut Nov 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayeut commented Nov 3, 2019

joerick commented Nov 4, 2019

mayeut commented Nov 4, 2019 • edited Loading

joerick commented Nov 4, 2019

mayeut commented Nov 4, 2019 • edited Loading

mayeut commented Nov 4, 2019

YannickJadoul commented Oct 30, 2019 •

edited

Loading

mayeut Nov 3, 2019 •

edited

Loading

mayeut commented Nov 4, 2019 •

edited

Loading

mayeut commented Nov 4, 2019 •

edited

Loading