Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the addtag subcommand #455

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove the addtag subcommand #455

merged 1 commit into from
Sep 26, 2023

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Sep 25, 2023

This subcommand has been broken for at least a few releases and doesn't provide any useful functionality. Removing it will at least avoid confusing users when they try to use it.

Closes: #444

@lkollar lkollar requested a review from mayeut September 25, 2023 19:55
This subcommand has been broken for at least a few releases and doesn't
provide any useful functionality. Removing it will at least avoid
confusing users when they try to use it.
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a809842) 92.30% compared to head (9d40f3a) 91.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   92.30%   91.89%   -0.41%     
==========================================
  Files          23       22       -1     
  Lines        1286     1246      -40     
  Branches      300      299       -1     
==========================================
- Hits         1187     1145      -42     
  Misses         57       57              
- Partials       42       44       +2     
Files Coverage Δ
src/auditwheel/main.py 94.28% <100.00%> (-5.72%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any consequence on removing the?

@mayeut mayeut merged commit 3636dad into pypa:main Sep 26, 2023
9 of 10 checks passed
@mayeut mayeut mentioned this pull request Sep 26, 2023
@mayeut mayeut mentioned this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addtag always tries to add linux_x86_64 tag
3 participants