Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addtag always tries to add linux_x86_64 tag #444

Closed
lkollar opened this issue Sep 4, 2023 · 2 comments · Fixed by #455
Closed

Addtag always tries to add linux_x86_64 tag #444

lkollar opened this issue Sep 4, 2023 · 2 comments · Fixed by #455

Comments

@lkollar
Copy link
Contributor

lkollar commented Sep 4, 2023

This might be a bug in addtag, but I'm not even sure what this subcommand is useful for. It seems to try to assign the minimum compatible tag in the file name, but from my limited testing it always ends up with the linux_x86_64 tag, which isn't useful. So if you pass a wheel which only has a linux_x86_64 tag, it does nothing, and for wheels which have manylinux tags it also adds linux_x86_64, which isn't very useful either. I wonder if this is a regression, as there aren't any real tests for this functionality...

Originally posted by @lkollar in #439 (comment)

@mayeut
Copy link
Member

mayeut commented Sep 8, 2023

I wonder if we should simply remove this command in auditwheel 6.0.0 ?
As you mentioned, I don't know how useful this is...

@lkollar
Copy link
Contributor Author

lkollar commented Sep 18, 2023

I'd in favour of removing it. It doesn't seem useful in its current form at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants