Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better fix for rtu incomplete frames #511

Merged
merged 2 commits into from
May 24, 2022
Merged

better fix for rtu incomplete frames #511

merged 2 commits into from
May 24, 2022

Conversation

sherpya
Copy link
Contributor

@sherpya sherpya commented Jul 9, 2020

  • avoid multiple calls to populateHeader()
  • trap IndexError in calculateRtuFrameSize()
  • more readable

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@janiversen janiversen mentioned this pull request Oct 7, 2020
Closed
@dhoomakethu
Copy link
Contributor

@sherpya I will be cherry picking this change to branch 2.5.0 after review. Thanks

@sfarbotka
Copy link

It seems this PR is fixing the same issue as #608 is.

@nikito7 nikito7 mentioned this pull request Oct 2, 2021
Closed
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sherpya @janiversen
better fix for rtu incomplete frames
2e50928 
- avoid multiple calls to populateHeader()
- trap IndexError in calculateRtuFrameSize()
- more readable
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

janiversen
janiversen approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, test passed and also in real life.

@janiversen janiversen merged commit f7fe305 into pymodbus-dev:dev May 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
IN REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherpya @dhoomakethu @sfarbotka @janiversen