-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modbus integration to use pymodbus 2.5.1 when available/stable #41415
Comments
Maintainers: feel free to assign this one to me. |
Hey there @adamchengtkc, @vzahradnik, mind taking a look at this issue as its been labeled with an integration ( |
Cross referencing this from pymodbus-dev/pymodbus#521. |
2.5.0 is officially released. Please check and report if any of the issues are still not resolved. |
Just filed PR #48585 to bump version. |
2.5.0 has a know regression which disconnects clients on each transaction. Please use 2.5.1rc1 |
@vzahradnik seems you got the afternoon free (I closed the PR), thank for volunteering. I am currently testing a bit with the pymodbus 3.0.0 branch, just to see when we can switch to async. |
pymodbus 2.5.1 is officially released. Thanks |
Thanks, I just saw it. Lets wait some days, and see if it is stable. |
The problem
A number of reported problems with the modbus integration is in reality problems in the 3rd party library.
Currently pymodbus 2.3.0 is used by the modbus integration. Pymodbus 2.5.0 is the newest version, but there are a tcp problem in that release so we wait to see a stable 2.5.1
This PR keeps track of the open issues and PR in pymodbus relevant for our integration.
The expectation is to close this PR when pymodbus 2.5.1 gets released.
Issues:
pymodbus-dev/pymodbus#510
Firsrst message is rejected
pymodbus-dev/pymodbus#496 (async error)
asyncio ModbusTCPFramer problems with splited answer
pymodbus-dev/pymodbus#560
Pull requests:
pymodbus-dev/pymodbus#511
better fix for rtu incomplete frames
pymodbus-dev/pymodbus#504
Fix comment and assertions in synchronous_client.py
pymodbus-dev/pymodbus#403
exception raising on incomplete message
Environment
Problem-relevant
configuration.yaml
Traceback/Error logs
Additional information
The text was updated successfully, but these errors were encountered: