Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modbus integration to use pymodbus 2.5.1 when available/stable #41415

Closed
janiversen opened this issue Oct 7, 2020 · 9 comments · Fixed by #49401
Closed

Update modbus integration to use pymodbus 2.5.1 when available/stable #41415

janiversen opened this issue Oct 7, 2020 · 9 comments · Fixed by #49401

Comments

@janiversen
Copy link
Member

janiversen commented Oct 7, 2020

The problem

A number of reported problems with the modbus integration is in reality problems in the 3rd party library.

Currently pymodbus 2.3.0 is used by the modbus integration. Pymodbus 2.5.0 is the newest version, but there are a tcp problem in that release so we wait to see a stable 2.5.1

This PR keeps track of the open issues and PR in pymodbus relevant for our integration.

The expectation is to close this PR when pymodbus 2.5.1 gets released.

Issues:
pymodbus-dev/pymodbus#510
Firsrst message is rejected

pymodbus-dev/pymodbus#496 (async error)
asyncio ModbusTCPFramer problems with splited answer

pymodbus-dev/pymodbus#560

Pull requests:
pymodbus-dev/pymodbus#511
better fix for rtu incomplete frames

pymodbus-dev/pymodbus#504
Fix comment and assertions in synchronous_client.py

pymodbus-dev/pymodbus#403
exception raising on incomplete message

Environment

  • Home Assistant Core release with the issue:
  • Last working Home Assistant Core release (if known):
  • Operating environment (OS/Container/Supervised/Core):
  • Integration causing this issue:
  • Link to integration documentation on our website:

Problem-relevant configuration.yaml

Traceback/Error logs

Additional information

@janiversen
Copy link
Member Author

Maintainers: feel free to assign this one to me.

@probot-home-assistant
Copy link

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this issue as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@dhoomakethu
Copy link

Cross referencing this from pymodbus-dev/pymodbus#521.
Please give it a spin with 2.5.0rc2. You can install from https://pypi.org/project/pymodbus/2.5.0rc2/ .
Refer https://github.com/riptideio/pymodbus/releases

@dhoomakethu
Copy link

2.5.0 is officially released. Please check and report if any of the issues are still not resolved.

@janiversen
Copy link
Member Author

Just filed PR #48585 to bump version.

@dhoomakethu
Copy link

2.5.0 has a know regression which disconnects clients on each transaction. Please use 2.5.1rc1

@janiversen janiversen changed the title Update modbus integration to use pymodbus 2.5.0 when available Update modbus integration to use pymodbus 2.5.1 when available/stable Mar 31, 2021
@janiversen
Copy link
Member Author

@vzahradnik seems you got the afternoon free (I closed the PR), thank for volunteering.

I am currently testing a bit with the pymodbus 3.0.0 branch, just to see when we can switch to async.

@dhoomakethu
Copy link

pymodbus 2.5.1 is officially released. Thanks

@janiversen
Copy link
Member Author

Thanks, I just saw it. Lets wait some days, and see if it is stable.

@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants