Bump pymodbus version to 2.5.0

[janiversen]

Breaking change

Proposed change

Bump pymodbus version to 2.5.0 since it now seems stable.

Version 2.5.0 have solved a number of issues (especially error handling) that should make the modbus integration more stable.

Release notes:
https://github.com/riptideio/pymodbus/releases

Compare v2.3.0 to v2.5.0
pymodbus-dev/pymodbus@v2.3.0...v2.5.0

Changelog:
https://github.com/riptideio/pymodbus/blob/master/CHANGELOG.rst

Type of change

• [x ] Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
  fixes Update modbus integration to use pymodbus 2.5.1 when available/stable #41415

• This PR is related to issue:

• Link to documentation pull request:

Checklist

• [x ] The code change is tested and works locally.
• [ x] Local tests pass. Your PR cannot be merged unless tests pass
• [ x] There is no commented out code in this PR.
• [ x] I have followed the development checklist
• [x ] The code has been formatted using Black (black --fast homeassistant tests)
• [x ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [x ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [x ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• [ x] No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[janiversen]

This works in my environment, but that is a small one.

@vzahradnik can you please give this a spin, before approving. Thanks in advance.

[probot-home-assistant]

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[frenck]

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

• A link to the release notes of this package version, and all versions in between.
• A link to the changelog of this package.
• A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

[janiversen]

Done, I hope I added what you need, otherwise just ask.

I would really like the approval from @vzahradnik before merging this, since he has a bigger modbus installation than I will ever get.

[vzahradnik]

@janiversen I will test your change today.

[janiversen]

Thanks a lot, but no need to stress yourself.

With v2.5.0 we can start thinking on trying the async again. In the meantime I am working to reduce the open issues, one by one.

[dhoomakethu]

Please use pyModbus 2.5.1rc1 . There was a regression in 2.5.0 which disconnects TCP connection after each transaction.

[janiversen]

Thanks for the advice, however I do not like to upgrade to a release candidate, so I will close this PR and wait until I see 2.5.1 as being stable.