Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pymodbus 2.2.0 #375

Merged
merged 24 commits into from
Apr 18, 2019
Merged

Pymodbus 2.2.0 #375

merged 24 commits into from
Apr 18, 2019

Conversation

dhoomakethu
Copy link
Contributor

Version 2.2.0

NOTE: Supports python 3.7, async client is now moved to pymodbus/client/asychronous

from pymodbus.client.asynchronous import ModbusTcpClient
  • Support Python 3.7
  • Fix AttributeError when setting interCharTimeout for serial clients.
  • Provide an option to disable inter char timeouts with Modbus RTU.
  • Add support to register custom requests in clients and server instances.
  • Fix read timeout calculation in ModbusTCP.
  • Fix SQLDbcontext always returning InvalidAddress error.
  • Fix SQLDbcontext update failure
  • Fix Binary payload example for endianess.
  • Fix tornado async serial client TypeError while processing incoming packet.
  • Fix asyncio examples.
  • Minor update in factory.py, now server logs prints received request instead of only function code
# Now
DEBUG:pymodbus.factory:Factory Request[ReadInputRegistersRequest: 4]
# Before
DEBUG:pymodbus.factory:Factory Request[4]

dhoomakethu and others added 12 commits December 3, 2018 15:31
@dhoomakethu
#357 Support registration of custom requests
a2d79e1
@mdmuhlbaier
#368 Fixes write to broadcast address
f07dcee 
When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.
@dhoomakethu
Bump version to 2.2.0
2e169b6 
Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes
@dhoomakethu
Merge branch '#357-Custom-Function' into pymodbus-2.2.0
c410f5b
@dhoomakethu
Fix #371 pymodbus repl on python3
826240b
@dhoomakethu
1. Fix tornado async serial client TypeError while processing incom…
6e72e44 
…ing packet.

2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod
@MarekLew @dhoomakethu
[fix v3] poprawa sprawdzania timeout
18fe036
@dhoomakethu
Release candidate for pymodbus 2.2.0
964a565
@dhoomakethu
Fix #377 when invalid port is supplied and minor updates in logging
6960d9c
@muhlbaier
Merge remote-tracking branch 'upstream/dev' into dev
249ad8f
@muhlbaier
#368 adds broadcast support for sync client and server
60aca50 
Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.
@muhlbaier
#368 Fixes minor bug in broadcast support code
e07e01e
@dhoomakethu dhoomakethu added this to the 2.2.0 milestone Feb 1, 2019
JStrbg and others added 5 commits February 11, 2019 09:13
@JStrbg @dhoomakethu
Fixed erronous CRC handling
5030514 
If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.
@dhoomakethu
Merge branch 'pull/372' into pymodbus-2.2.0
1a24c1d
@dhoomakethu
Update Changelog
e5c2615
@dhoomakethu
Fix test coverage
f66f464
@dhoomakethu
Fix #387 Transactions failing on 2.2.0rc2.
7650421
@AtibaBryan
Copy link

👍👍👍👍👍👍👍👍 I could really use this. I'm trying to make an async server to test something and am running into this issue right now #391

pazzarpj and others added 2 commits March 6, 2019 09:55
@pazzarpj @dhoomakethu
Task Cancellation and CRC Errors
6233706 
Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response
@dhoomakethu
Cherry pick commit from PR #367 , Update changelog , bump version to …
89d3909 
…2.2.0rc4
@dhoomakethu dhoomakethu mentioned this pull request Mar 6, 2019
Closed
@pazzarpj
Copy link

pazzarpj commented Mar 13, 2019 •
edited
Loading

Testing RTU in 2.2.0RC4

Test Setup

Siemans IOT2040 running python 3.5.2 on embedded linux.

pip install async-timeout
pip install pymodbus==2.2.0rc4

Using the following test script

test_script.py 
import async_timeout
import asyncio
from pymodbus.client.sync import ModbusSerialClient as Client
from pymodbus.client.asynchronous.serial import AsyncModbusSerialClient
from pymodbus.client.asynchronous.schedulers import ASYNC_IO
import logging

logging.basicConfig(level=logging.INFO)

log = logging.getLogger(__file__)
#
port = '/dev/ttyS2'
log.info("Getting values for all 3 devices")
s_client = Client(method='rtu', port=port, timeout=0.5,parity='N', stopbits=1, baudrate=19200)
s1 = s_client.read_holding_registers(0, 1, unit=1)
log.info(s1)
s2 = s_client.read_holding_registers(0, 10, unit=2)
log.info(s2)
s3 = s_client.read_holding_registers(0, 10, unit=3)
log.info(s3)
log.warning("Setup Sync Failure Mode")
input()
for x in range(15):
    resp = s_client.read_holding_registers(0, 1, unit=1)
    if resp.isError():
        log.info("{}".format(resp))
    else:
        if s1.registers == resp.registers:
            log.info("Slave 1 Response - {}".format(resp.registers))
        else:
            log.error("Slave 1 expected - {}, Actual - {}".format(s1.registers, resp.registers))

    resp = s_client.read_holding_registers(0, 10, unit=2)
    if resp.isError():
        log.info("{}".format(resp))
    else:
        if s2.registers == resp.registers:
            log.info("Slave 2 Response - {}".format(resp.registers))
        else:
            log.error("Slave 2 expected - {}, Actual - {}".format(s2.registers, resp.registers))

    resp = s_client.read_holding_registers(0, 10, unit=3)
    if resp.isError():
        log.info("{}".format(resp))
    else:
        if s3.registers == resp.registers:
            log.info("Slave 3 Response - {}".format(resp.registers))
        else:
            log.error("Slave 3 expected - {}, Actual - {}".format(s3.registers, resp.registers))

s_client.close()
log.warning("Set up async failure mode")
input()
log.warning("Starting async transactions!!")
loop, client = AsyncModbusSerialClient(ASYNC_IO, method='rtu', port=port, parity='N', baudrate=19200,
                                       stopbits=1)


async def spam():
    while True:
        # Slave 1
        # resp = await  client.protocol.read_holding_registers(0, 1, unit=1)
        try:
            with async_timeout.timeout(0.5):
                resp = await client.protocol.read_holding_registers(0, 1, unit=1)
                if resp.isError():
                    log.info("{}".format(resp))
                else:
                    if s1.registers == resp.registers:
                        log.info("Slave 1 Response - {}".format(resp.registers))
                    else:
                        log.error("Slave 1 expected - {}, Actual - {}".format(s1.registers, resp.registers))
        except asyncio.TimeoutError:
            log.warning("Timeout on Slave 1")
        # # Slave 2
        try:
            with async_timeout.timeout(0.5):
                resp = await client.protocol.read_holding_registers(0, 10, unit=2)
                if resp.isError():
                    log.info("{}".format(resp))
                else:
                    if s2.registers == resp.registers:
                        log.info("Slave 2 Response - {}".format(resp.registers))
                    else:
                        log.error("Slave 2 expected - {}, Actual - {}".format(s2.registers, resp.registers))

        except asyncio.TimeoutError:
            log.warning("Timeout on Slave 2")

        # Slave 3
        try:
            with async_timeout.timeout(0.5):
                resp = await client.protocol.read_holding_registers(0, 10, unit=3)
                if resp.isError():
                    log.info("{}".format(resp))
                else:
                    if s3.registers == resp.registers:
                        log.info("Slave 3 Response - {}".format(resp.registers))
                    else:
                        log.error("Slave 3 expected - {}, Actual - {}".format(s3.registers, resp.registers))

        except asyncio.TimeoutError:
            log.warning("Timeout on Slave 3")


if __name__ == "__main__":
    import logging

    loop.run_until_complete(spam())
    loop.close()
Slave setup Window 10 64 bit. Running software

Modbus Slave

Unit 1 HR 0-9 values of 1-10
Unit 2 HR 0-9 values of 21-30
Unit 3 HR 0-9 values of 31-40

Results

Note that the async client does not have a timeout field natively, so I am using mechanisms within asyncio for task cancellation after a specified time. Without this, the async client can hang indefinitely awaiting for a response that never comes.

No errors behaves as expected.

No Error Conditions 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]

Random CRC behaves as expected.
Sync Client returns modbus error of no response returned.
Async Client just the async timeout.
Perhaps invalid CRC frames could raise an appropriate response when resetting frame (if it is even possible to know if you have a full frame with CRC error)

Random CRC errors injected on all 3 Slaves 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
WARNING:test_thing.py:Timeout on Slave 1
WARNING:test_thing.py:Timeout on Slave 2
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
WARNING:test_thing.py:Timeout on Slave 1
WARNING:test_thing.py:Timeout on Slave 2
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]

Slave busy behaves as expected and returns the exception response for both sync and async clients.

Slave 3 is busy 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Exception Response(131, 3, SlaveBusy)
INFO:test_thing.py:Slave 1 Response - [1]

Behaves as expected.
Sync client returns Modbus Error
Async client times out.
Both recover on the next transaction

Slave 3 skips random responses 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Modbus Error: [Input/Output] Modbus Error: [Invalid Message] Incomplete message received, expected at least 2 bytes (0 received)
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Modbus Error: [Input/Output] Modbus Error: [Invalid Message] Incomplete message received, expected at least 2 bytes (0 received)
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]

Simulating a delayed response that is less than the timeout, behaves exactly the same as the no errors case.

Slave 3 400ms Delay 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]

Setting the Slave 3 to respond to the request 600ms after receiving it, this is 100ms slower than the timeout case. This means that the next request will have already been sent.
This test case should be very rare for any well behaved modbus slave.
The Async Client discards the delayed response but still responds to the subsequent request.
The Sync Client gets confused with the out frame response.

Slave 3 600ms Delay 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Modbus Error: [Input/Output] Modbus Error: [Invalid Message] Incomplete message received, expected at least 2 bytes (0 received)
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:test_thing.py:Set up async failure mode
WARNING:test_thing.py:Starting async transactions!!
INFO:pymodbus.client.asynchronous.asyncio:Protocol made connection.
INFO:pymodbus.client.asynchronous.asyncio:Connected to /dev/ttyS2
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
WARNING:test_thing.py:Timeout on Slave 3
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]

Tried again by turning back to 0ms half way through sync client reads and it seemed to recover then.

Turn 600ms back on half way through sync only 
INFO:test_thing.py:Getting values for all 3 devices
INFO:test_thing.py:ReadRegisterResponse (1)
INFO:test_thing.py:ReadRegisterResponse (10)
INFO:test_thing.py:ReadRegisterResponse (10)
WARNING:test_thing.py:Setup Sync Failure Mode
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Modbus Error: [Input/Output] Modbus Error: [Invalid Message] Incomplete message received, expected at least 2 bytes (0 received)
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x1c 0x0 0x1d 0x0 0x1e 0xc4 0xce
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
INFO:test_thing.py:Modbus Error: [Input/Output] No Response received from the remote unit/Unable to decode response
WARNING:pymodbus.client.sync:Cleanup recv buffer before send: 0x0 0x21 0x0 0x22 0x0 0x23 0x0 0x24 0x0 0x25 0x0 0x26 0x0 0x27 0x0 0x28 0xeb 0xad 0x1 0x3 0x2 0x0 0x1 0x79 0x84
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
INFO:test_thing.py:Slave 1 Response - [1]
INFO:test_thing.py:Slave 2 Response - [21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
INFO:test_thing.py:Slave 3 Response - [31, 32, 33, 34, 35, 36, 37, 38, 39, 40]

@dhoomakethu dhoomakethu merged commit 9ff42d1 into dev Apr 18, 2019
dhoomakethu added a commit that referenced this pull request Apr 18, 2019
@dhoomakethu
Pymodbus v2.2.0 (#406)
2ef91e9 
* Rebase to dev3.7

* Adding 3.7 to travis configuration

* Updated documentation to resolve warnings introduced with the longer names
Updated requirements-docs.txt to include missing modules

* Fixed reference to deprecated asynchronous

* Adding gmp disable to fix pypy build issues

* Adding gmp disable to fix pypy build issues

* Removing travis python 3.7 configuration

Commenting out python3.7 from Travis while waiting for support. You can run teh 3.7 tests with tox without issues

* Adding asserts for Payload Endianness

* Fixing example of Payload. Same Endianness for builder and decoder.

* Fix Sql db slave context validate and get methods - #139

* #353 - debugging, Add debug logs to check size of avaialble data in read buffer

* #353 Provide an option to disable inter char timeouts

* #353 Bump version, update changelog

* check self.socket (#354)

* check self.socket

self.socket might be None at this point

* Update pymodbus/client/sync.py

Co-Authored-By: mpf82 <[email protected]>

* Fix typo (#378)

* Pymodbus 2.2.0 (#375)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* #389 Support passing all serial port parameters to asynchronous server

* Fix BinaryPayloadDecoder and Builder wrt to coils

* Misc updates, bump version to 2.2.0

* ReportSlaveIdResponse now tries to get slave id based on server identity for pymodbus servers

* Update missing bcrypt requirement for testing
dhoomakethu added a commit that referenced this pull request Apr 19, 2019
@dhoomakethu
Doc generation patch (#408)
31c1650 
* Rebase to dev3.7

* Adding 3.7 to travis configuration

* Updated documentation to resolve warnings introduced with the longer names
Updated requirements-docs.txt to include missing modules

* Fixed reference to deprecated asynchronous

* Adding gmp disable to fix pypy build issues

* Adding gmp disable to fix pypy build issues

* Removing travis python 3.7 configuration

Commenting out python3.7 from Travis while waiting for support. You can run teh 3.7 tests with tox without issues

* Adding asserts for Payload Endianness

* Fixing example of Payload. Same Endianness for builder and decoder.

* Fix Sql db slave context validate and get methods - #139

* #353 - debugging, Add debug logs to check size of avaialble data in read buffer

* #353 Provide an option to disable inter char timeouts

* #353 Bump version, update changelog

* check self.socket (#354)

* check self.socket

self.socket might be None at this point

* Update pymodbus/client/sync.py

Co-Authored-By: mpf82 <[email protected]>

* Fix typo (#378)

* Pymodbus 2.2.0 (#375)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* #389 Support passing all serial port parameters to asynchronous server

* Fix BinaryPayloadDecoder and Builder wrt to coils

* Misc updates, bump version to 2.2.0

* ReportSlaveIdResponse now tries to get slave id based on server identity for pymodbus servers

* Update missing bcrypt requirement for testing

* Fix docs (#407)

* Fix document generation

* Formatting updates in Changelog
dhoomakethu added a commit that referenced this pull request Oct 29, 2019
@dhoomakethu
Pymodbus v2.3.0 (#452)
fbdc470 
* Rebase to dev3.7

* Adding 3.7 to travis configuration

* Updated documentation to resolve warnings introduced with the longer names
Updated requirements-docs.txt to include missing modules

* Fixed reference to deprecated asynchronous

* Adding gmp disable to fix pypy build issues

* Adding gmp disable to fix pypy build issues

* Removing travis python 3.7 configuration

Commenting out python3.7 from Travis while waiting for support. You can run teh 3.7 tests with tox without issues

* Adding asserts for Payload Endianness

* Fixing example of Payload. Same Endianness for builder and decoder.

* Fix Sql db slave context validate and get methods - #139

* #353 - debugging, Add debug logs to check size of avaialble data in read buffer

* #353 Provide an option to disable inter char timeouts

* #353 Bump version, update changelog

* check self.socket (#354)

* check self.socket

self.socket might be None at this point

* Update pymodbus/client/sync.py

Co-Authored-By: mpf82 <[email protected]>

* Fix typo (#378)

* Pymodbus 2.2.0 (#375)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* #389 Support passing all serial port parameters to asynchronous server

* Fix BinaryPayloadDecoder and Builder wrt to coils

* Misc updates, bump version to 2.2.0

* ReportSlaveIdResponse now tries to get slave id based on server identity for pymodbus servers

* Update missing bcrypt requirement for testing

* Fix docs (#407)

* Fix document generation

* Formatting updates in Changelog

* Remove pycrypto dep (#411)

It has not been needed by Twisted for a long time, and has been unmaintained
for a long time.

* Fix --upgrade option in install dependencies (#413)

* Fix document generation

* Formatting updates in Changelog

* Fix --upgrade option in install dependencies

* Padding for odd sized responses (#425)

If the response is odd size the buffer needs to be padded with an additional byte.

* README update: REPL stands for Read Evaluate **Print** Loop (#426)

* Drop python 3.4 support (#440)

Python 3.4 is EoL and has an easy upgrade path to 3.5+. Support was
dropped in Twisted 19.7.0, which is causing Travis to fail pymodbus
tests for 3.4.

* Re-enable travis python 3.7 builds (#441)

* Update __init__.py (#436)

* Use SPDX identifier to specify the exact license type (#427)

* asyncio server implementation (#400)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* native asyncio implementation of ModbusTcpServer and ModbusUdpServer

* preliminary asyncio server examples

* move serial module dependency into class instantiation

* unittests for asyncio based server implementation

* induce exception in execute method by mock patching the request object's execute method

* move serial module dependency into class instantiation

* added asynctest depency to requirements-tests.txt

* add unittest skip condition for unsupported targets, remove failing assertion from unsupported targets, use lower asynctest version

* remove logger setLevel call since doing so may override library consumers' already set log level

* remove async def/await keywords from unittest so that the ast can be loaded in py2 even if the test is to be skipped

* Add option to repl allowing Modbus RTU framing on a TCP socket (#447)

* repl: Allow Modbus RTU framing on a TCP socket

* repl: Update README for framing option

* Fix asynci server test failures on python3.6 and below

* Bump version to 2.2.0rc1, update six requirements and Changelog

* Support multiple Python versions to fix test error from PR #400 (#444)

* client/sync.py: Fix missing serial module dependency

The serial.connect failed in PR riptideio#400 with "NameError: name
'serial' is not defined" [1]:

self = <ModbusSerialClient at 0x7fcda4009b00 socket=None, method=ascii, timeout=3>

    def connect(self):
        """ Connect to the modbus serial server

        :returns: True if connection succeeded, False otherwise
        """
        if self.socket:
            return True
        try:
>           self.socket = serial.Serial(port=self.port,
                                        timeout=self.timeout,
                                        bytesize=self.bytesize,
                                        stopbits=self.stopbits,
                                        baudrate=self.baudrate,
                                        parity=self.parity)
E                                       NameError: name 'serial' is not defined

pymodbus/client/sync.py:476: NameError

This patch moves the serial import back to the head.

[1] https://travis-ci.org/riptideio/pymodbus/jobs/566009109

Fixes: commit e6da559 asyncio server implementation (#400)

* server/asyncio.py: Create server with appropriate args and environment

If Python is older than 3.7, the create_server will fail like PR
riptideio#400 with "unexpected keyword argument 'start_serving'" [1]
which is new in Python version 3.7:

self.server_factory = self.loop.create_server(lambda :self.handler(self),
                                              *self.address,
                                              reuse_address=allow_reuse_address,
                                              reuse_port=allow_reuse_port,
                                              backlog=backlog,
>                                             start_serving=not defer_start)

E       TypeError: create_server() got an unexpected keyword argument 'start_serving'

pymodbus/server/asyncio.py:400: TypeError

This patch creates server according to Python environment.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584178484

Fixes: commit e6da559 asyncio server implementation (#400)

* Create asyncio task with appropriate method and environment

If Python is older than 3.7, the asyncio.create_task will fail like PR
riptideio#400 with "AttributeError: module 'asyncio' has no attribute
'create_task'" [1] which is new in Python version 3.7 [2]:

@asyncio.coroutine

def testTcpServerCloseActiveConnection(self):
    ''' Test server_close() while there are active TCP connections'''
    data = b"\x01\x00\x00\x00\x00\x06\x01\x01\x00\x00\x00\x01"
    server = yield from StartTcpServer(context=self.context,address=("127.0.0.1", 0),loop=self.loop)
>   server_task = asyncio.create_task(server.serve_forever())
E   AttributeError: module 'asyncio' has no attribute 'create_task'

test/test_server_asyncio.py:205: AttributeError

This patch creates task according to Python environment.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584193587
[2] https://docs.python.org/3/library/asyncio-task.html#creating-tasks

Fixes: commit e6da559 asyncio server implementation (#400)

* server/asyncio.py: Fix format string for older Python

If Python is older than 3.6, f-Strings will fail like PR riptideio#400
with "SyntaxError: invalid syntax" [1] which is new in Python version
3.6 with PEP 498 -- Literal String Interpolation [2]:

test/test_server_asyncio.py:14: in <module>
    from pymodbus.server.asyncio import StartTcpServer, StartUdpServer, StartSerialServer, StopServer, ModbusServerFactory
E     File "/home/travis/build/starnight/pymodbus/pymodbus/server/asyncio.py", line 424
E       _logger.warning(f"aborting active session {k}")
E                                                    ^
E   SyntaxError: invalid syntax

This patch fixes the format string with traditional format string
syntax.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584427976
[2] https://www.python.org/dev/peps/pep-0498/

Fixes: commit e6da559 asyncio server implementation (#400)

* test: Make assert_called_once() test only with Python 3.6+

If Python is older than 3.6, unittest.mock.assert_called_once() will
fail like PR riptideio#400 with "AttributeError: assert_called_once" [1]
which is new in Python version 3.6 [2]:

>       self.loop.create_server.assert_called_once()

test/test_server_asyncio.py:76:

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <CoroutineMock name='mock.create_server' id='139638313234784'>
name = 'assert_called_once'

    def __getattr__(self, name):
        if name in {'_mock_methods', '_mock_unsafe'}:
            raise AttributeError(name)
        elif self._mock_methods is not None:
            if name not in self._mock_methods or name in _all_magics:
                raise AttributeError("Mock object has no attribute %r" % name)
        elif _is_magic(name):
            raise AttributeError(name)
        if not self._mock_unsafe:
            if name.startswith(('assert', 'assret')):
>               raise AttributeError(name)
E               AttributeError: assert_called_once

/opt/python/3.5.6/lib/python3.5/unittest/mock.py:585: AttributeError

This patch skips the tests if they are not in Python 3.6+.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584431003
[2] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_once

Fixes: commit e6da559 asyncio server implementation (#400)

* test: Make serve_forever() test only with Python 3.7+

If Python is older than 3.7, asyncio.base_events.Server.serve_forever
will fail like PR riptideio#400 with "AttributeError: <class
'asyncio.base_events.Server'> does not have the attribute
'serve_forever'" [1] which is new in Python version 3.7 [2]:

@asyncio.coroutine
def testTcpServerServeNoDefer(self):
    ''' Test StartTcpServer without deferred start (immediate execution of server) '''
>   with patch('asyncio.base_events.Server.serve_forever', new_callable=asynctest.CoroutineMock) as serve:

test/test_server_asyncio.py:81:

...

if not self.create and original is DEFAULT:
    raise AttributeError(
>       "%s does not have the attribute %r" % (target, name)
    )
E   AttributeError: <class 'asyncio.base_events.Server'> does not have the attribute 'serve_forever'

This patch skips the tests if they are not in Python 3.7+.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584212511
[2] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.Server.serve_forever

Fixes: commit e6da559 asyncio server implementation (#400)

* Add TLS feature for Modbus synchronous (#446)

* Add TLS feature for Modbus synchronous

Modbus.org released MODBUS/TCP Security Protocol Specification [1],
which focuses variant of the Mobdbus/TCP protocol utilizing Transport
Layer Security (TLS). This patch enables the Modbus over TLS feature as
ModbusTlsClient with the Python builtin module ssl - TLS/SSL wrapper for
socket objects.

[1]: http://modbus.org/docs/MB-TCP-Security-v21_2018-07-24.pdf

* Implement MODBUS TLS synchronous server

Since we have the MODBUS TLS synchronous client, we can also have the
MODBUS TLS synchronous server.

* Fix #461 - Udp client/server , Fix #401 - package license with source, #457 Fix typo's in docstrings, #455-Support float16

* Fix examples, Merge #431

* #401 Move license to root folder from docs
dhoomakethu added a commit that referenced this pull request Sep 11, 2020
@dhoomakethu @dices
@EricDuminil @mpf82 @kimhanse @tracernz @acanidio @tcplomp @alecjohanson @hackerboygn @yegorich @memetb @Sekenre @starnight @stv0g @a-andreyev @wildstray @sumpfralle
Pymodbus v2.4.0 (#520)
8ef3299 
* Rebase to dev3.7

* Adding 3.7 to travis configuration

* Updated documentation to resolve warnings introduced with the longer names
Updated requirements-docs.txt to include missing modules

* Fixed reference to deprecated asynchronous

* Adding gmp disable to fix pypy build issues

* Adding gmp disable to fix pypy build issues

* Removing travis python 3.7 configuration

Commenting out python3.7 from Travis while waiting for support. You can run teh 3.7 tests with tox without issues

* Adding asserts for Payload Endianness

* Fixing example of Payload. Same Endianness for builder and decoder.

* Fix Sql db slave context validate and get methods - #139

* #353 - debugging, Add debug logs to check size of avaialble data in read buffer

* #353 Provide an option to disable inter char timeouts

* #353 Bump version, update changelog

* check self.socket (#354)

* check self.socket

self.socket might be None at this point

* Update pymodbus/client/sync.py

Co-Authored-By: mpf82 <[email protected]>

* Fix typo (#378)

* Pymodbus 2.2.0 (#375)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* #389 Support passing all serial port parameters to asynchronous server

* Fix BinaryPayloadDecoder and Builder wrt to coils

* Misc updates, bump version to 2.2.0

* ReportSlaveIdResponse now tries to get slave id based on server identity for pymodbus servers

* Update missing bcrypt requirement for testing

* Fix docs (#407)

* Fix document generation

* Formatting updates in Changelog

* Remove pycrypto dep (#411)

It has not been needed by Twisted for a long time, and has been unmaintained
for a long time.

* Fix --upgrade option in install dependencies (#413)

* Fix document generation

* Formatting updates in Changelog

* Fix --upgrade option in install dependencies

* Padding for odd sized responses (#425)

If the response is odd size the buffer needs to be padded with an additional byte.

* README update: REPL stands for Read Evaluate **Print** Loop (#426)

* Drop python 3.4 support (#440)

Python 3.4 is EoL and has an easy upgrade path to 3.5+. Support was
dropped in Twisted 19.7.0, which is causing Travis to fail pymodbus
tests for 3.4.

* Re-enable travis python 3.7 builds (#441)

* Update __init__.py (#436)

* Use SPDX identifier to specify the exact license type (#427)

* asyncio server implementation (#400)

* #357 Support registration of custom requests

* #368 Fixes write to broadcast address

When writing to broadcast address (unit_id=0) there should be no response according to the Modbus spec. This fix changes expected_response_length to 0 when writing to unit_id=0. This will break any existing code that is improperly using unit_id 0 for a slave address.

* Bump version to 2.2.0

Fix #366 Update failures in sql context

Update Changelog

Fix major minor version in example codes

* Fix #371 pymodbus repl on python3

* 1. Fix tornado async serial client `TypeError` while processing incoming packet.
2. Fix asyncio examples.
3. Minor update in factory.py, now server logs prints received request instead of only function cod

* [fix v3] poprawa sprawdzania timeout

* Release candidate for pymodbus 2.2.0

*  Fix #377 when invalid port is supplied and minor updates in logging

* #368 adds broadcast support for sync client and server

Adds broadcast_enable parameter to client and server, default value is False. When true it will treat unit_id 0 as broadcast and execute requests on all server slave contexts and not send a response and on the client side will send the request and not try to receive a response.

* #368 Fixes minor bug in broadcast support code

* Fixed erronous CRC handling

If the CRC recieved is not correct in my case my slave got caught in a deadlock, not taking any new requests. This addition fixed that.

* Update Changelog

* Fix test coverage

* Fix #387 Transactions failing on 2.2.0rc2.

* Task Cancellation and CRC Errors

Alternate solution for #356 and #360.

Changes the RTU to make the transaction ID as the unit ID instead of an ever incrementing number.

Previously this transaction ID was always 0 on the receiving end but was the unique transaction ID on sending.

As such the FIFO buffer made the most sense. By tying it to the unit ID, we can recover from failure modes such as: -
- Asyncio task cancellations (eg. timeouts) #360
- Skipped responses from slaves. (hangs on master #360)
- CRC Errors #356
- Busy response

* Cherry pick commit from PR #367 , Update changelog , bump version to 2.2.0rc4

* native asyncio implementation of ModbusTcpServer and ModbusUdpServer

* preliminary asyncio server examples

* move serial module dependency into class instantiation

* unittests for asyncio based server implementation

* induce exception in execute method by mock patching the request object's execute method

* move serial module dependency into class instantiation

* added asynctest depency to requirements-tests.txt

* add unittest skip condition for unsupported targets, remove failing assertion from unsupported targets, use lower asynctest version

* remove logger setLevel call since doing so may override library consumers' already set log level

* remove async def/await keywords from unittest so that the ast can be loaded in py2 even if the test is to be skipped

* Add option to repl allowing Modbus RTU framing on a TCP socket (#447)

* repl: Allow Modbus RTU framing on a TCP socket

* repl: Update README for framing option

* Fix asynci server test failures on python3.6 and below

* Bump version to 2.2.0rc1, update six requirements and Changelog

* Support multiple Python versions to fix test error from PR #400 (#444)

* client/sync.py: Fix missing serial module dependency

The serial.connect failed in PR riptideio#400 with "NameError: name
'serial' is not defined" [1]:

self = <ModbusSerialClient at 0x7fcda4009b00 socket=None, method=ascii, timeout=3>

    def connect(self):
        """ Connect to the modbus serial server

        :returns: True if connection succeeded, False otherwise
        """
        if self.socket:
            return True
        try:
>           self.socket = serial.Serial(port=self.port,
                                        timeout=self.timeout,
                                        bytesize=self.bytesize,
                                        stopbits=self.stopbits,
                                        baudrate=self.baudrate,
                                        parity=self.parity)
E                                       NameError: name 'serial' is not defined

pymodbus/client/sync.py:476: NameError

This patch moves the serial import back to the head.

[1] https://travis-ci.org/riptideio/pymodbus/jobs/566009109

Fixes: commit e6da559 asyncio server implementation (#400)

* server/asyncio.py: Create server with appropriate args and environment

If Python is older than 3.7, the create_server will fail like PR
riptideio#400 with "unexpected keyword argument 'start_serving'" [1]
which is new in Python version 3.7:

self.server_factory = self.loop.create_server(lambda :self.handler(self),
                                              *self.address,
                                              reuse_address=allow_reuse_address,
                                              reuse_port=allow_reuse_port,
                                              backlog=backlog,
>                                             start_serving=not defer_start)

E       TypeError: create_server() got an unexpected keyword argument 'start_serving'

pymodbus/server/asyncio.py:400: TypeError

This patch creates server according to Python environment.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584178484

Fixes: commit e6da559 asyncio server implementation (#400)

* Create asyncio task with appropriate method and environment

If Python is older than 3.7, the asyncio.create_task will fail like PR
riptideio#400 with "AttributeError: module 'asyncio' has no attribute
'create_task'" [1] which is new in Python version 3.7 [2]:

@asyncio.coroutine

def testTcpServerCloseActiveConnection(self):
    ''' Test server_close() while there are active TCP connections'''
    data = b"\x01\x00\x00\x00\x00\x06\x01\x01\x00\x00\x00\x01"
    server = yield from StartTcpServer(context=self.context,address=("127.0.0.1", 0),loop=self.loop)
>   server_task = asyncio.create_task(server.serve_forever())
E   AttributeError: module 'asyncio' has no attribute 'create_task'

test/test_server_asyncio.py:205: AttributeError

This patch creates task according to Python environment.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584193587
[2] https://docs.python.org/3/library/asyncio-task.html#creating-tasks

Fixes: commit e6da559 asyncio server implementation (#400)

* server/asyncio.py: Fix format string for older Python

If Python is older than 3.6, f-Strings will fail like PR riptideio#400
with "SyntaxError: invalid syntax" [1] which is new in Python version
3.6 with PEP 498 -- Literal String Interpolation [2]:

test/test_server_asyncio.py:14: in <module>
    from pymodbus.server.asyncio import StartTcpServer, StartUdpServer, StartSerialServer, StopServer, ModbusServerFactory
E     File "/home/travis/build/starnight/pymodbus/pymodbus/server/asyncio.py", line 424
E       _logger.warning(f"aborting active session {k}")
E                                                    ^
E   SyntaxError: invalid syntax

This patch fixes the format string with traditional format string
syntax.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584427976
[2] https://www.python.org/dev/peps/pep-0498/

Fixes: commit e6da559 asyncio server implementation (#400)

* test: Make assert_called_once() test only with Python 3.6+

If Python is older than 3.6, unittest.mock.assert_called_once() will
fail like PR riptideio#400 with "AttributeError: assert_called_once" [1]
which is new in Python version 3.6 [2]:

>       self.loop.create_server.assert_called_once()

test/test_server_asyncio.py:76:

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <CoroutineMock name='mock.create_server' id='139638313234784'>
name = 'assert_called_once'

    def __getattr__(self, name):
        if name in {'_mock_methods', '_mock_unsafe'}:
            raise AttributeError(name)
        elif self._mock_methods is not None:
            if name not in self._mock_methods or name in _all_magics:
                raise AttributeError("Mock object has no attribute %r" % name)
        elif _is_magic(name):
            raise AttributeError(name)
        if not self._mock_unsafe:
            if name.startswith(('assert', 'assret')):
>               raise AttributeError(name)
E               AttributeError: assert_called_once

/opt/python/3.5.6/lib/python3.5/unittest/mock.py:585: AttributeError

This patch skips the tests if they are not in Python 3.6+.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584431003
[2] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_once

Fixes: commit e6da559 asyncio server implementation (#400)

* test: Make serve_forever() test only with Python 3.7+

If Python is older than 3.7, asyncio.base_events.Server.serve_forever
will fail like PR riptideio#400 with "AttributeError: <class
'asyncio.base_events.Server'> does not have the attribute
'serve_forever'" [1] which is new in Python version 3.7 [2]:

@asyncio.coroutine
def testTcpServerServeNoDefer(self):
    ''' Test StartTcpServer without deferred start (immediate execution of server) '''
>   with patch('asyncio.base_events.Server.serve_forever', new_callable=asynctest.CoroutineMock) as serve:

test/test_server_asyncio.py:81:

...

if not self.create and original is DEFAULT:
    raise AttributeError(
>       "%s does not have the attribute %r" % (target, name)
    )
E   AttributeError: <class 'asyncio.base_events.Server'> does not have the attribute 'serve_forever'

This patch skips the tests if they are not in Python 3.7+.

[1] https://travis-ci.org/starnight/pymodbus/jobs/584212511
[2] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.Server.serve_forever

Fixes: commit e6da559 asyncio server implementation (#400)

* Add TLS feature for Modbus synchronous (#446)

* Add TLS feature for Modbus synchronous

Modbus.org released MODBUS/TCP Security Protocol Specification [1],
which focuses variant of the Mobdbus/TCP protocol utilizing Transport
Layer Security (TLS). This patch enables the Modbus over TLS feature as
ModbusTlsClient with the Python builtin module ssl - TLS/SSL wrapper for
socket objects.

[1]: http://modbus.org/docs/MB-TCP-Security-v21_2018-07-24.pdf

* Implement MODBUS TLS synchronous server

Since we have the MODBUS TLS synchronous client, we can also have the
MODBUS TLS synchronous server.

* Fix #461 - Udp client/server , Fix #401 - package license with source, #457 Fix typo's in docstrings, #455-Support float16

* Fix examples, Merge #431

* #401 Move license to root folder from docs

* rtu_framer: fix processing of incomplete frames (#466)

* rtu_framer: fix processing of incomplete frames

* rtu_framer: fix test case

* Add handle local echo option

* Update constants.py

Added RetryOnInvalid flag and Backoff delay.

* Update transaction.py

Added retry on invalid data received and exponetial backoff delay between retries.

* Add TLS feature for Modbus asynchronous (#470)

* Add TLS feature for Modbus asynchronous client

Since we have Modbus TLS client in synchronous mode, we can also
implement Modbus TLS client in asynchronous mode with ASYNC_IO.

* Add TLS feature for Modbus asynchronous server

Since we have Modbus TLS server in synchronous mode, we can also
implement Modbus TLS server in asynchronous mode with ASYNC_IO.

* PR #471 Fix transaction tests

* Fix failing tests

* Add "Python" trove classifier

Previously only generic "Python" support (without a version) was announced.

* Merge PR's , bump version to 2.4.0

* closes #481, #482, #483, #484

* Closes  #491

* Asyncio bug fixes (#517)

* Closes  #491

* 1. update requirements
2. Fix examples
3. Fix #494 - handle_local_echo
4. Fix #500 -- asyncio serial client with already running loop
5. Fix #486 - Pass serial args for asyncio serial client
6. Fix #490 - Typo in decode_data for socker_framer
7. Fix #385 - Support timeouts to break out of responspe await when server goes offline
8. Misc updates

* #516 custom data block fix

* Update Changelogs , bump version to 2.4.0

* #515 fix repl broadcast (#531)

* 1. update requirements
2. Fix examples
3. Fix #494 - handle_local_echo
4. Fix #500 -- asyncio serial client with already running loop
5. Fix #486 - Pass serial args for asyncio serial client
6. Fix #490 - Typo in decode_data for socker_framer
7. Fix #385 - Support timeouts to break out of responspe await when server goes offline
8. Misc updates

* #516 custom data block fix

* Fix broadcast error  with REPL client #515

* Fix #509 Wrong unit ID referenced in framers

* Update documentation for serial forwarder example. Fixes #525

* Fix unit tests, support python 3.8 for tests, renamed:    pymodbus/server/asyncio.py -> pymodbus/server/async_io.py and pymodbus/client/asynchronous/asyncio -> pymodbus/client/asynchronous/async_io

* Ignore python3 code syntax while reporting coverage

* Fix tests failing on python 3.6 and osx

* Fix typo in makefile

* Fix test execution errors specific to python3.6

* Osx travis issue - Fix trial 1

* Travis reverting xcode to 8.x for mac osx

* Pymodbus v2.4.0

Co-authored-by: dices <[email protected]>
Co-authored-by: Eric Duminil <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Kim Hansen <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Andrea Canidio <[email protected]>
Co-authored-by: tcplomp <[email protected]>
Co-authored-by: alecjohanson <[email protected]>
Co-authored-by: hackerboygn <[email protected]>
Co-authored-by: Yegor Yefremov <[email protected]>
Co-authored-by: Memet Bilgin <[email protected]>
Co-authored-by: Sekenre <[email protected]>
Co-authored-by: sanjay <[email protected]>
Co-authored-by: Jian-Hong Pan <[email protected]>
Co-authored-by: Steffen Vogel <[email protected]>
Co-authored-by: Alexey Andreyev <[email protected]>
Co-authored-by: Wild Stray <[email protected]>
Co-authored-by: Lars Kruse <[email protected]>
@janiversen janiversen deleted the pymodbus-2.2.0 branch April 5, 2022 07:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
IN REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dhoomakethu @AtibaBryan @pazzarpj @mdmuhlbaier @MarekLew @muhlbaier @JStrbg